Обсуждение: Re: [ADMIN] compression -Fx "problem"

Поиск
Список
Период
Сортировка

Re: [ADMIN] compression -Fx "problem"

От
Tom Lane
Дата:
Peter Eisentraut <peter_e@gmx.net> writes:
> This has got to stop.  We've seen "my cursor keys don't work in psql", now
> we see "compression doesn't work" every so often.  Somehow we have to get
> deterministic output from configure without "paying attention".  Either
> require these libraries by default (my preference) or not, but not "take
> what's there".

So you're thinking "error out unless user said --without-zlib or
--without-readline"?

I could live with that, assuming that the error message mentioned that
switch as the way to build without the library.
        regards, tom lane


Re: [ADMIN] compression -Fx "problem"

От
Bruce Momjian
Дата:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > This has got to stop.  We've seen "my cursor keys don't work in psql", now
> > we see "compression doesn't work" every so often.  Somehow we have to get
> > deterministic output from configure without "paying attention".  Either
> > require these libraries by default (my preference) or not, but not "take
> > what's there".
> 
> So you're thinking "error out unless user said --without-zlib or
> --without-readline"?

Or --my_cursor_keys_will_never_work_in_psql.  :-)

Not sure if they are going to make the connection between
--without-readline and psql cursor keys.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


Re: [ADMIN] compression -Fx "problem"

От
Bruce Momjian
Дата:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > This has got to stop.  We've seen "my cursor keys don't work in psql", now
> > we see "compression doesn't work" every so often.  Somehow we have to get
> > deterministic output from configure without "paying attention".  Either
> > require these libraries by default (my preference) or not, but not "take
> > what's there".
> 
> So you're thinking "error out unless user said --without-zlib or
> --without-readline"?
> 
> I could live with that, assuming that the error message mentioned that
> switch as the way to build without the library.

What I have seen some packages do is to report unusual configure
findings just a configure exits.  Something like:
Your psql cursor keys will not work because readline wasn't found

or something like that for zlib.

Added to TODO:
* Report failure to find readline or zlib at end of configure run

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


Re: [ADMIN] compression -Fx "problem"

От
Tom Lane
Дата:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Added to TODO:
>     * Report failure to find readline or zlib at end of configure run

Peter will certainly not consider that an acceptable answer, since it
helps not at all for non-interactive builds.
        regards, tom lane


Re: [ADMIN] compression -Fx "problem"

От
Andrew McMillan
Дата:
On Sat, 2001-12-29 at 09:05, Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Added to TODO:
> >     * Report failure to find readline or zlib at end of configure run
> 
> Peter will certainly not consider that an acceptable answer, since it
> helps not at all for non-interactive builds.
> 

Doing that sort of thing is a huge improvement though.  Hopefully the
people who are doing auto builds have done them manually a few times
first!

To take it a bit further though, you could perhaps have it refuse to
continue beyond that without an explicit configure option.  That would
then stop the auto build as well.

Regards,                Andrew.
-- 
--------------------------------------------------------------------
Andrew @ Catalyst .Net.NZ Ltd, PO Box 11-053, Manners St, Wellington
WEB: http://catalyst.net.nz/        PHYS: Level 2, 150-154 Willis St
DDI: +64(4)916-7201    MOB: +64(21)635-694    OFFICE: +64(4)499-2267      Are you enrolled at
http://schoolreunions.co.nz/yet?