Обсуждение: pg_attribute typo??

Поиск
Список
Период
Сортировка

pg_attribute typo??

От
Keith Parks
Дата:
Bruce,

Just noticed the following warning when compiling for the
umpteenth time ;-)


gcc -I../../../include -I../../../backend   -O2  -Wall -Wmissing-prototypes -g
-I../..   -c relcache.c -o relcache.o
relcache.c:110: warning: multi-character character constant
relcache.c:110: warning: overflow in implicit constant conversion

Upon investigation I find what should be a 'd' was a 'd '

Here's a patch.

Keith.

*** ./src/include/catalog/pg_attribute.h.orig   Wed Aug 26 19:19:35 1998
--- ./src/include/catalog/pg_attribute.h        Wed Aug 26 19:20:26 1998
***************
*** 317,323 ****
   */
  #define Schema_pg_attribute \
  { 1249, {"attrelid"},   26, 0,        4,      1, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
! { 1249, {"attname"},    19, 0, NAMEDATALEN,   2, 0, -1, -1, '\0', '\0', 'd ',
'\0', '\0' }, \
  { 1249, {"atttypid"},   26, 0,        4,      3, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attdisbursion"}, 700, 0,    4,      4, 0, -1, -1, '\0', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attlen"},             21, 0,        2,      5, 0, -1, -1, '\001',
'\0', 's', '\0', '\0' }, \
--- 317,323 ----
   */
  #define Schema_pg_attribute \
  { 1249, {"attrelid"},   26, 0,        4,      1, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
! { 1249, {"attname"},    19, 0, NAMEDATALEN,   2, 0, -1, -1, '\0', '\0', 'd',
'\0', '\0' }, \
  { 1249, {"atttypid"},   26, 0,        4,      3, 0, -1, -1, '\001', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attdisbursion"}, 700, 0,    4,      4, 0, -1, -1, '\0', '\0', 'i',
'\0', '\0' }, \
  { 1249, {"attlen"},             21, 0,        2,      5, 0, -1, -1, '\001',
'\0', 's', '\0', '\0' }, \

Re: pg_attribute typo??

От
Bruce Momjian
Дата:
> Bruce,
>
> Just noticed the following warning when compiling for the
> umpteenth time ;-)
>
>
> gcc -I../../../include -I../../../backend   -O2  -Wall -Wmissing-prototypes -g
> -I../..   -c relcache.c -o relcache.o
> relcache.c:110: warning: multi-character character constant
> relcache.c:110: warning: overflow in implicit constant conversion
>
> Upon investigation I find what should be a 'd' was a 'd '
>
> Here's a patch.
>

Applied.  Thanks.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)