Обсуждение: Crash Backend in 7.3.1

This crashes for me.  I know it's a syntax error, but others are handled more gracefully.

7.3.1 on NetBSD 1.5.2 i386

create table test (
        testid int
        );

create or replace function test_trig() returns trigger as '

elog NOTICE
return OK

' language 'pltcl';

create trigger test_btrig before insert on test for each row execute procedure test_trig();

insert into test values (1);


Ian Harding
Programmer/Analyst II
Tacoma-Pierce County Health Department
iharding@tpchd.org
(253) 798-3549

"If any man can convince me and bring home to me that I do not think or act aright, gladly will I change; for I search
aftertruth, by which man never yet was harmed. But he is harmed who abideth on still in his deception and ignorance" 

              -- Marcus Aurelius

"Ian Harding" <ianh@tpchd.org> writes:
> This crashes for me.

Yeah, me too (in current sources, too, not 7.3).

I have to leave for awhile, but will look at it later if no one beats me
to it.

            regards, tom lane

"Ian Harding" <ianh@tpchd.org> writes:
> This crashes for me.  I know it's a syntax error, but others are handled more gracefully.

Fixed --- pltcl_elog was trying to be cute about error handling, but got
it wrong in this one code path.  It's probably not worth your trouble to
apply the patch manually; just don't call elog with the wrong number of
parameters ;-)

Thanks for the report.

            regards, tom lane