Обсуждение: Regression tests failing on abstime due to test date being before 'current'

Поиск
Список
Период
Сортировка

Regression tests failing on abstime due to test date being before 'current'

От
Lincoln Yeoh
Дата:
From: expected/abstime.out

SELECT '' AS six, ABSTIME_TBL.*
   WHERE ABSTIME_TBL.f1 < abstime 'Jun 30, 2001';
 six |              f1
-----+------------------------------
     | Sun Jan 14 03:14:21 1973 PST
     | Mon May 01 00:30:30 1995 PDT
     | epoch
     | current
     | -infinity
     | Sat May 10 23:59:12 1947 PST
(6 rows)

---
In my system current is now after Jun 30 and so doesn't appear. If the test
passes it's actually a huge problem ;).

Is it necessary to pick dates so close in the "future" when setting up the
test? How about setting such dates to some date when the next version is
likely to be out :). Then at least if it fails it's a convenient time to
ask newbies to upgrade to 7.X or even 8.

It's just a very minor issue, but this has happened before - one release
had the testdate < Y2K.

Cheerio,
Link.



Re: Regression tests failing on abstime due to test date being before 'current'

От
Bruce Momjian
Дата:
We have fixed this in the current source and the fix will be in 7.2.  We
missed this until it was too late.


> From: expected/abstime.out
>
> SELECT '' AS six, ABSTIME_TBL.*
>    WHERE ABSTIME_TBL.f1 < abstime 'Jun 30, 2001';
>  six |              f1
> -----+------------------------------
>      | Sun Jan 14 03:14:21 1973 PST
>      | Mon May 01 00:30:30 1995 PDT
>      | epoch
>      | current
>      | -infinity
>      | Sat May 10 23:59:12 1947 PST
> (6 rows)
>
> ---
> In my system current is now after Jun 30 and so doesn't appear. If the test
> passes it's actually a huge problem ;).
>
> Is it necessary to pick dates so close in the "future" when setting up the
> test? How about setting such dates to some date when the next version is
> likely to be out :). Then at least if it fails it's a convenient time to
> ask newbies to upgrade to 7.X or even 8.
>
> It's just a very minor issue, but this has happened before - one release
> had the testdate < Y2K.
>
> Cheerio,
> Link.
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://www.postgresql.org/search.mpl
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026