Обсуждение: Minor errors in plpgsql and plperl examples..

Поиск
Список
Период
Сортировка

Minor errors in plpgsql and plperl examples..

От
Philip Hallstrom
Дата:
Hi -

There are two errors involving single quotes in the following documents.

http://www.postgresql.org/docs/user/c40874340.htm
- In the code for "PL/pgSQL Trigger Procedure" the initial single quote is
missing.  Currently the line reads:

   CREATE FUNCTION emp_stamp () RETURNS OPAQUE AS

All the other examples have a single quote right after "AS".



http://www.postgresql.org/docs/user/pl-perl4538.htm
- The last example is:

  CREATE FUNCTION empcomp(employee) returns int4
    AS 'my $emp = shift;
        return $emp->{'basesalary'} + $emp->{'bonus'};'
    LANGUAGE 'plperl';


Shouldn't the single quotes on the "return" line be escaped?


(i've never used postgresql so maybe this is all incorrect, but just
reading through the docs -- which are very very nice btw)

-philip


Re: Minor errors in plpgsql and plperl examples..

От
Bruce Momjian
Дата:
I have fixed both of these in the current sources.  Thanks much.


> Hi -
>
> There are two errors involving single quotes in the following documents.
>
> http://www.postgresql.org/docs/user/c40874340.htm
> - In the code for "PL/pgSQL Trigger Procedure" the initial single quote is
> missing.  Currently the line reads:
>
>    CREATE FUNCTION emp_stamp () RETURNS OPAQUE AS
>
> All the other examples have a single quote right after "AS".
>
>
>
> http://www.postgresql.org/docs/user/pl-perl4538.htm
> - The last example is:
>
>   CREATE FUNCTION empcomp(employee) returns int4
>     AS 'my $emp = shift;
>         return $emp->{'basesalary'} + $emp->{'bonus'};'
>     LANGUAGE 'plperl';
>
>
> Shouldn't the single quotes on the "return" line be escaped?
>
>
> (i've never used postgresql so maybe this is all incorrect, but just
> reading through the docs -- which are very very nice btw)
>
> -philip
>
>


--
  Bruce Momjian                        |  http://www.op.net/~candle
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026