Обсуждение: pgsql: Add word_similarity to pg_trgm contrib module.
Add word_similarity to pg_trgm contrib module. Patch introduces a concept of similarity over string and just a word from another string. Version of extension is not changed because 1.2 was already introduced in 9.6 release cycle, so, there wasn't a public version. Author: Alexander Korotkov, Artur Zakirov Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/f576b17cd6ba653bdace1f0da9a3b57f4984e460 Modified Files -------------- contrib/pg_trgm/Makefile | 2 +- contrib/pg_trgm/expected/pg_trgm.out | 4 +- contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 ++++- contrib/pg_trgm/pg_trgm--1.2.sql | 64 +++++ contrib/pg_trgm/sql/pg_trgm.sql | 4 +- contrib/pg_trgm/trgm.h | 30 +- contrib/pg_trgm/trgm_gin.c | 20 +- contrib/pg_trgm/trgm_gist.c | 33 ++- contrib/pg_trgm/trgm_op.c | 501 ++++++++++++++++++++++++++++++---- doc/src/sgml/pgtrgm.sgml | 79 ++++++ 10 files changed, 726 insertions(+), 75 deletions(-)
Teodor Sigaev <teodor@sigaev.ru> writes:
> Modified Files
> --------------
> contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 ++++-
> contrib/pg_trgm/pg_trgm--1.2.sql | 64 +++++
This is completely, utterly wrong. You do not add stuff to an extension
module by redefining what version 1.2 means. You do it by creating a 1.3
version and providing a 1.2--1.3 update script.
regards, tom lane
On Wed, Mar 16, 2016 at 12:40 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Teodor Sigaev <teodor@sigaev.ru> writes: >> Modified Files >> -------------- >> contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 ++++- >> contrib/pg_trgm/pg_trgm--1.2.sql | 64 +++++ > > This is completely, utterly wrong. You do not add stuff to an extension > module by redefining what version 1.2 means. You do it by creating a 1.3 > version and providing a 1.2--1.3 update script. Uh, did you read his commit message? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Mar 16, 2016 at 12:40 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This is completely, utterly wrong. You do not add stuff to an extension
>> module by redefining what version 1.2 means. You do it by creating a 1.3
>> version and providing a 1.2--1.3 update script.
> Uh, did you read his commit message?
Ah, sorry, I failed to absorb the point. My apologies.
regards, tom lane
>> contrib/pg_trgm/pg_trgm--1.1--1.2.sql | 64 ++++- >> contrib/pg_trgm/pg_trgm--1.2.sql | 64 +++++ > > This is completely, utterly wrong. You do not add stuff to an extension > module by redefining what version 1.2 means. You do it by creating a 1.3 > version and providing a 1.2--1.3 update script. http://www.postgresql.org/message-id/25977.1452717421@sss.pgh.pa.us You had an opposite opinion three months ago. And I still agree with that. -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/