pgsql: Improve support of Hunspell in ispell dictionary.
pgsql: Improve support of Hunspell in ispell dictionary.
От:
Teodor Sigaev <teodor@sigaev.ru>
Дата:
Improve support of Hunspell in ispell dictionary. Now it's possible to load recent version of Hunspell for several languages. To handle these dictionaries Hunspell patch adds support for: * FLAG long - sets the double extended ASCII character flag type * FLAG num - sets the decimal number flag type (from 1 to 65535) * AF parameter - alias for flag's set Also it moves test dictionaries into separate directory. Author: Artur Zakirov with editorization by me Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/d78a7d9c7fa3e9cd494b906f065fe7b7fe9fb9a5 Modified Files -------------- doc/src/sgml/textsearch.sgml | 148 ++++- src/backend/tsearch/Makefile | 7 +- src/backend/tsearch/dicts/hunspell_sample.affix | 24 + .../tsearch/dicts/hunspell_sample_long.affix | 35 ++ .../tsearch/dicts/hunspell_sample_long.dict | 8 + .../tsearch/dicts/hunspell_sample_num.affix | 26 + src/backend/tsearch/dicts/hunspell_sample_num.dict | 8 + src/backend/tsearch/dicts/ispell_sample.affix | 26 + src/backend/tsearch/dicts/ispell_sample.dict | 8 + src/backend/tsearch/dicts/synonym_sample.syn | 5 + src/backend/tsearch/dicts/thesaurus_sample.ths | 17 + src/backend/tsearch/hunspell_sample.affix | 24 - src/backend/tsearch/ispell_sample.affix | 26 - src/backend/tsearch/ispell_sample.dict | 8 - src/backend/tsearch/spell.c | 611 ++++++++++++++++++--- src/backend/tsearch/synonym_sample.syn | 5 - src/backend/tsearch/thesaurus_sample.ths | 17 - src/include/tsearch/dicts/spell.h | 51 +- src/test/regress/expected/tsdicts.out | 234 ++++++++ src/test/regress/sql/tsdicts.sql | 64 +++ 20 files changed, 1183 insertions(+), 169 deletions(-)
Re: pgsql: Improve support of Hunspell in ispell dictionary.
Thank you for commit. This commit did not pass regression tests in Windows Server in pgbuildfarm. Attached patch fix it. On 04.03.2016 20:08, Teodor Sigaev wrote: > Improve support of Hunspell in ispell dictionary. > > Now it's possible to load recent version of Hunspell for several languages. > To handle these dictionaries Hunspell patch adds support for: > * FLAG long - sets the double extended ASCII character flag type > * FLAG num - sets the decimal number flag type (from 1 to 65535) > * AF parameter - alias for flag's set > > Also it moves test dictionaries into separate directory. > > Author: Artur Zakirov with editorization by me > > Branch > ------ > master > > Details > ------- > http://git.postgresql.org/pg/commitdiff/d78a7d9c7fa3e9cd494b906f065fe7b7fe9fb9a5 > > Modified Files > -------------- > doc/src/sgml/textsearch.sgml | 148 ++++- > src/backend/tsearch/Makefile | 7 +- > src/backend/tsearch/dicts/hunspell_sample.affix | 24 + > .../tsearch/dicts/hunspell_sample_long.affix | 35 ++ > .../tsearch/dicts/hunspell_sample_long.dict | 8 + > .../tsearch/dicts/hunspell_sample_num.affix | 26 + > src/backend/tsearch/dicts/hunspell_sample_num.dict | 8 + > src/backend/tsearch/dicts/ispell_sample.affix | 26 + > src/backend/tsearch/dicts/ispell_sample.dict | 8 + > src/backend/tsearch/dicts/synonym_sample.syn | 5 + > src/backend/tsearch/dicts/thesaurus_sample.ths | 17 + > src/backend/tsearch/hunspell_sample.affix | 24 - > src/backend/tsearch/ispell_sample.affix | 26 - > src/backend/tsearch/ispell_sample.dict | 8 - > src/backend/tsearch/spell.c | 611 ++++++++++++++++++--- > src/backend/tsearch/synonym_sample.syn | 5 - > src/backend/tsearch/thesaurus_sample.ths | 17 - > src/include/tsearch/dicts/spell.h | 51 +- > src/test/regress/expected/tsdicts.out | 234 ++++++++ > src/test/regress/sql/tsdicts.sql | 64 +++ > 20 files changed, 1183 insertions(+), 169 deletions(-) > > -- Artur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company
Re: pgsql: Improve support of Hunspell in ispell dictionary.
От:
Teodor Sigaev <teodor@sigaev.ru>
Дата:
Thank you, pushed
Artur Zakirov wrote:
> Thank you for commit.
>
> This commit did not pass regression tests in Windows Server in pgbuildfarm.
> Attached patch fix it.
>
> On 04.03.2016 20:08, Teodor Sigaev wrote:
>> Improve support of Hunspell in ispell dictionary.
>>
>> Now it's possible to load recent version of Hunspell for several languages.
>> To handle these dictionaries Hunspell patch adds support for:
>> * FLAG long - sets the double extended ASCII character flag type
>> * FLAG num - sets the decimal number flag type (from 1 to 65535)
>> * AF parameter - alias for flag's set
>>
>> Also it moves test dictionaries into separate directory.
>>
>> Author: Artur Zakirov with editorization by me
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> http://git.postgresql.org/pg/commitdiff/d78a7d9c7fa3e9cd494b906f065fe7b7fe9fb9a5
>>
>> Modified Files
>> --------------
>> doc/src/sgml/textsearch.sgml | 148 ++++-
>> src/backend/tsearch/Makefile | 7 +-
>> src/backend/tsearch/dicts/hunspell_sample.affix | 24 +
>> .../tsearch/dicts/hunspell_sample_long.affix | 35 ++
>> .../tsearch/dicts/hunspell_sample_long.dict | 8 +
>> .../tsearch/dicts/hunspell_sample_num.affix | 26 +
>> src/backend/tsearch/dicts/hunspell_sample_num.dict | 8 +
>> src/backend/tsearch/dicts/ispell_sample.affix | 26 +
>> src/backend/tsearch/dicts/ispell_sample.dict | 8 +
>> src/backend/tsearch/dicts/synonym_sample.syn | 5 +
>> src/backend/tsearch/dicts/thesaurus_sample.ths | 17 +
>> src/backend/tsearch/hunspell_sample.affix | 24 -
>> src/backend/tsearch/ispell_sample.affix | 26 -
>> src/backend/tsearch/ispell_sample.dict | 8 -
>> src/backend/tsearch/spell.c | 611 ++++++++++++++++++---
>> src/backend/tsearch/synonym_sample.syn | 5 -
>> src/backend/tsearch/thesaurus_sample.ths | 17 -
>> src/include/tsearch/dicts/spell.h | 51 +-
>> src/test/regress/expected/tsdicts.out | 234 ++++++++
>> src/test/regress/sql/tsdicts.sql | 64 +++
>> 20 files changed, 1183 insertions(+), 169 deletions(-)
>>
>>
>
>
--
Teodor Sigaev E-mail: teodor@sigaev.ru
WWW: http://www.sigaev.ru/
Re: pgsql: Improve support of Hunspell in ispell dictionary.
От:
Peter Eisentraut <peter_e@gmx.net>
Дата:
On 3/4/16 12:08 PM, Teodor Sigaev wrote: > Improve support of Hunspell in ispell dictionary. > > Now it's possible to load recent version of Hunspell for several languages. > To handle these dictionaries Hunspell patch adds support for: > * FLAG long - sets the double extended ASCII character flag type > * FLAG num - sets the decimal number flag type (from 1 to 65535) > * AF parameter - alias for flag's set > > Also it moves test dictionaries into separate directory. Are the blank lines at the end of the new affix sample files necessary?
Re: pgsql: Improve support of Hunspell in ispell dictionary.
От:
Artur Zakirov <a.zakirov@postgrespro.ru>
Дата:
On 06.03.2016 17:53, Peter Eisentraut wrote: > On 3/4/16 12:08 PM, Teodor Sigaev wrote: >> Improve support of Hunspell in ispell dictionary. >> >> Now it's possible to load recent version of Hunspell for several languages. >> To handle these dictionaries Hunspell patch adds support for: >> * FLAG long - sets the double extended ASCII character flag type >> * FLAG num - sets the decimal number flag type (from 1 to 65535) >> * AF parameter - alias for flag's set >> >> Also it moves test dictionaries into separate directory. > > Are the blank lines at the end of the new affix sample files necessary? > > > Actually this blank lines are not necessary. New affix sample files was just copied from hunspell_sample.affix and modified. The hunspell_sample.affix has two blank lines at the end before and after the commit too, if I am not mistaken. The ispell_sample.affix and the ispell_sample.dict have one blank line at the end before and after the commit. -- Artur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company
Re: pgsql: Improve support of Hunspell in ispell dictionary.
От:
Peter Eisentraut <peter_e@gmx.net>
Дата:
On 3/4/16 12:08 PM, Teodor Sigaev wrote: > Improve support of Hunspell in ispell dictionary. > > Now it's possible to load recent version of Hunspell for several languages. > To handle these dictionaries Hunspell patch adds support for: > * FLAG long - sets the double extended ASCII character flag type > * FLAG num - sets the decimal number flag type (from 1 to 65535) > * AF parameter - alias for flag's set > > Also it moves test dictionaries into separate directory. The uninstall target in src/backend/tsearch/Makefile doesn't work anymore, because it tries to uninstall from, e.g., share/tsearch_data/dicts/hunspell_sample_long.dict, but the files are at share/tsearch_data/dicts/hunspell_sample_long.dict .
Re: pgsql: Improve support of Hunspell in ispell dictionary.
On 07.03.2016 17:49, Peter Eisentraut wrote: > On 3/4/16 12:08 PM, Teodor Sigaev wrote: >> Improve support of Hunspell in ispell dictionary. >> >> Now it's possible to load recent version of Hunspell for several languages. >> To handle these dictionaries Hunspell patch adds support for: >> * FLAG long - sets the double extended ASCII character flag type >> * FLAG num - sets the decimal number flag type (from 1 to 65535) >> * AF parameter - alias for flag's set >> >> Also it moves test dictionaries into separate directory. > > The uninstall target in src/backend/tsearch/Makefile doesn't work > anymore, because it tries to uninstall from, e.g., > share/tsearch_data/dicts/hunspell_sample_long.dict, but the files are at > share/tsearch_data/dicts/hunspell_sample_long.dict . > > > Thank you for notice that. Indeed. It is my fault. Attached patch should fix it. -- Artur Zakirov Postgres Professional: http://www.postgrespro.com Russian Postgres Company
Re: pgsql: Improve support of Hunspell in ispell dictionary.
От:
Peter Eisentraut <peter_e@gmx.net>
Дата:
On 3/7/16 4:03 PM, Artur Zakirov wrote: > On 07.03.2016 17:49, Peter Eisentraut wrote: >> The uninstall target in src/backend/tsearch/Makefile doesn't work >> anymore, because it tries to uninstall from, e.g., >> share/tsearch_data/dicts/hunspell_sample_long.dict, but the files are at >> share/tsearch_data/dicts/hunspell_sample_long.dict . > > Thank you for notice that. Indeed. It is my fault. > > Attached patch should fix it. Thanks.