Обсуждение: pgsql: Fix oversight in tsearch type check
Fix oversight in tsearch type check Use IsBinaryCoercible() method instead of custom is_expected_type/is_text_type functions which was introduced when tsearch2 was moved into core. Per report by David E. Wheeler Analysis by Tom Lane Patch by me Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/9acb9007de30b3daaa9efc16763c3bc6e3e0a92d Modified Files -------------- src/backend/utils/adt/tsvector_op.c | 42 ++++------------------------------- 1 file changed, 4 insertions(+), 38 deletions(-)
On 9/17/15 12:51 PM, Teodor Sigaev wrote: > Fix oversight in tsearch type check > > Use IsBinaryCoercible() method instead of custom > is_expected_type/is_text_type functions which was introduced when tsearch2 > was moved into core. Looks like you need to add an include file: tsvector_op.c: In function 'ts_stat_sql': tsvector_op.c:1135:4: error: implicit declaration of function 'IsBinaryCoercible' [-Werror=implicit-function-declaration] !IsBinaryCoercible(SPI_gettypeid(SPI_tuptable->tupdesc, 1), ^
Thank you, fixed Peter Eisentraut wrote: > On 9/17/15 12:51 PM, Teodor Sigaev wrote: >> Fix oversight in tsearch type check >> >> Use IsBinaryCoercible() method instead of custom >> is_expected_type/is_text_type functions which was introduced when tsearch2 >> was moved into core. > > Looks like you need to add an include file: > > tsvector_op.c: In function 'ts_stat_sql': > tsvector_op.c:1135:4: error: implicit declaration of function > 'IsBinaryCoercible' [-Werror=implicit-function-declaration] > !IsBinaryCoercible(SPI_gettypeid(SPI_tuptable->tupdesc, 1), > ^ > > > -- Teodor Sigaev E-mail: teodor@sigaev.ru WWW: http://www.sigaev.ru/