Обсуждение: pgsql: Move pg_test_fsync from contrib/ to src/bin/

Поиск
Список
Период
Сортировка

pgsql: Move pg_test_fsync from contrib/ to src/bin/

От
Peter Eisentraut
Дата:
Move pg_test_fsync from contrib/ to src/bin/

Reviewed-by: Michael Paquier <michael.paquier@gmail.com>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/00882d9e5ce7b693aa536346f68a826064c8683a

Modified Files
--------------
contrib/Makefile                      |    1 -
contrib/pg_test_fsync/.gitignore      |    1 -
contrib/pg_test_fsync/Makefile        |   18 -
contrib/pg_test_fsync/pg_test_fsync.c |  603 ---------------------------------
doc/src/sgml/contrib.sgml             |    1 -
doc/src/sgml/filelist.sgml            |    1 -
doc/src/sgml/pgtestfsync.sgml         |  121 -------
doc/src/sgml/ref/allfiles.sgml        |    1 +
doc/src/sgml/ref/pgtestfsync.sgml     |  113 ++++++
doc/src/sgml/reference.sgml           |    1 +
src/bin/Makefile                      |    1 +
src/bin/pg_test_fsync/.gitignore      |    1 +
src/bin/pg_test_fsync/Makefile        |   27 ++
src/bin/pg_test_fsync/pg_test_fsync.c |  603 +++++++++++++++++++++++++++++++++
src/tools/msvc/Mkvcbuild.pm           |    8 +-
15 files changed, 751 insertions(+), 750 deletions(-)


Re: pgsql: Move pg_test_fsync from contrib/ to src/bin/

От
Michael Paquier
Дата:
On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Move pg_test_fsync from contrib/ to src/bin/

Point of detail that I just noticed: wouldn't it be better to have a
header in pg_test_fsync.c of a shape similar to the other files. Now
there is only that:
/*
 *    pg_test_fsync.c
 *        tests all supported fsync() methods
 */
An idea what this gives as a patch is attached.
--
Michael

Вложения

Re: [COMMITTERS] pgsql: Move pg_test_fsync from contrib/ to src/bin/

От
Bruce Momjian
Дата:
On Mon, Apr 20, 2015 at 02:51:10PM +0900, Michael Paquier wrote:
> On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > Move pg_test_fsync from contrib/ to src/bin/
> 
> Point of detail that I just noticed: wouldn't it be better to have a
> header in pg_test_fsync.c of a shape similar to the other files. Now
> there is only that:
> /*
>  *    pg_test_fsync.c
>  *        tests all supported fsync() methods
>  */
> An idea what this gives as a patch is attached.

This patch is old but the header is still missing, so patch applied to
master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.