Обсуждение: pgsql: vacuumdb: enable parallel mode
vacuumdb: enable parallel mode This mode allows vacuumdb to open several server connections to vacuum or analyze several tables simultaneously. Author: Dilip Kumar. Some reworking by Álvaro Herrera Reviewed by: Jeff Janes, Amit Kapila, Magnus Hagander, Andres Freund Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/a17923204736d8842eade3517d6a8ee81290fca4 Modified Files -------------- doc/src/sgml/ref/vacuumdb.sgml | 24 ++ src/bin/pg_dump/parallel.c | 2 +- src/bin/scripts/common.c | 23 +- src/bin/scripts/common.h | 6 + src/bin/scripts/vacuumdb.c | 797 ++++++++++++++++++++++++++++++++-------- 5 files changed, 691 insertions(+), 161 deletions(-)
On Sat, Jan 24, 2015 at 3:06 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> vacuumdb: enable parallel mode
>
> This mode allows vacuumdb to open several server connections to vacuum
> or analyze several tables simultaneously.
Coverity is still complaining about this block of code where the
return code of PQsendQuery() is not checked:
if (async)
{
if (echo)
printf("%s\n", sql);
PQsendQuery(conn, sql);
}
Could it be possible to get that fixed soon? Alvaro, attached is the
patch that you wrote to fix this stuff.
Regards,
--
Michael
Вложения
Michael Paquier wrote: > On Sat, Jan 24, 2015 at 3:06 AM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > > vacuumdb: enable parallel mode > > > > This mode allows vacuumdb to open several server connections to vacuum > > or analyze several tables simultaneously. > > Coverity is still complaining about this block of code where the > return code of PQsendQuery() is not checked: Should be fixed now, thanks. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services