Обсуждение: pgsql: Rename logical decoding's pg_llog directory to pg_logical.
Rename logical decoding's pg_llog directory to pg_logical. The old name wasn't very descriptive as of actual contents of the directory, which are historical snapshots in the snapshots/ subdirectory and mappingdata for rewritten tuples in mappings/. There's been a fair amount of discussion what would be a good name. I'm settling for pg_logical because it's likely that further data around logical decoding and replication will need saving in the future. Also add the missing entry for the directory into storage.sgml's list of PGDATA contents. Bumps catversion as the data directories won't be compatible. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/a36a8fa376631e59d006772bcd30f4f827d7e6b9 Modified Files -------------- doc/src/sgml/storage.sgml | 5 +++++ src/backend/access/heap/rewriteheap.c | 10 +++++----- src/backend/replication/logical/reorderbuffer.c | 6 +++--- src/backend/replication/logical/snapbuild.c | 20 ++++++++++---------- src/bin/initdb/initdb.c | 6 +++--- src/include/catalog/catversion.h | 2 +- 6 files changed, 27 insertions(+), 22 deletions(-)
On Thu, Jul 3, 2014 at 4:08 AM, Andres Freund <andres@anarazel.de> wrote:
--
Michael
Rename logical decoding's pg_llog directory to pg_logical.
The old name wasn't very descriptive as of actual contents of the
directory, which are historical snapshots in the snapshots/
subdirectory and mappingdata for rewritten tuples in
mappings/. There's been a fair amount of discussion what would be a
good name. I'm settling for pg_logical because it's likely that
further data around logical decoding and replication will need saving
in the future.
Also add the missing entry for the directory into storage.sgml's list
of PGDATA contents.
Bumps catversion as the data directories won't be compatible.
Shouldn't this commit be backpatched as well to REL9_4_STABLE. I am failing to see the point of having the folder used for logical decoding named pg_llog in 9.4 and pg_logical in 9.5. This is creating inconsistencies between major versions.
Regards,
Michael
Michael Paquier <michael.paquier@gmail.com> writes:
> On Thu, Jul 3, 2014 at 4:08 AM, Andres Freund <andres@anarazel.de> wrote:
>> Rename logical decoding's pg_llog directory to pg_logical.
> Shouldn't this commit be backpatched as well to REL9_4_STABLE.
Indeed --- I supposed it had been, but looking at the commit logs,
I see it wasn't. This is not good.
regards, tom lane
On 2014-07-09 13:00:15 +0900, Michael Paquier wrote: > On Thu, Jul 3, 2014 at 4:08 AM, Andres Freund <andres@anarazel.de> wrote: > > > Rename logical decoding's pg_llog directory to pg_logical. > > > > The old name wasn't very descriptive as of actual contents of the > > directory, which are historical snapshots in the snapshots/ > > subdirectory and mappingdata for rewritten tuples in > > mappings/. There's been a fair amount of discussion what would be a > > good name. I'm settling for pg_logical because it's likely that > > further data around logical decoding and replication will need saving > > in the future. > > > > Also add the missing entry for the directory into storage.sgml's list > > of PGDATA contents. > > > > Bumps catversion as the data directories won't be compatible. > > > Shouldn't this commit be backpatched as well to REL9_4_STABLE. I am failing > to see the point of having the folder used for logical decoding named > pg_llog in 9.4 and pg_logical in 9.5. This is creating inconsistencies > between major versions. Yes, you're right. Will backpatch. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services