Change plan caching to honor, not resist, changes in search_path.
In the initial implementation of plan caching, we saved the active
search_path when a plan was first cached, then reinstalled that path
anytime we needed to reparse or replan. The idea of that was to try to
reselect the same referenced objects, in somewhat the same way that views
continue to refer to the same objects in the face of schema or name
changes. Of course, that analogy doesn't bear close inspection, since
holding the search_path fixed doesn't cope with object drops or renames.
Moreover sticking with the old path seems to create more surprises than
it avoids. So instead of doing that, consider that the cached plan depends
on search_path, and force reparse/replan if the active search_path is
different than it was when we last saved the plan.
This gets us fairly close to having "transparency" of plan caching, in the
sense that the cached statement acts the same as if you'd just resubmitted
the original query text for another execution. There are still some corner
cases where this fails though: a new object added in the search path
schema(s) might capture a reference in the query text, but we'd not realize
that and force a reparse. We might try to fix that in the future, but for
the moment it looks too expensive and complicated.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/0d5fbdc157a17abc379052f5099b1c29a33cebe2
Modified Files
--------------
doc/src/sgml/plpgsql.sgml | 4 +-
doc/src/sgml/ref/prepare.sgml | 22 ++++++++
doc/src/sgml/spi.sgml | 14 +++++
src/backend/catalog/namespace.c | 22 ++++++++
src/backend/utils/cache/plancache.c | 84 ++++++++++++++++---------------
src/include/catalog/namespace.h | 1 +
src/include/utils/plancache.h | 3 +-
src/test/regress/expected/plancache.out | 6 +-
src/test/regress/sql/plancache.sql | 2 +-
9 files changed, 111 insertions(+), 47 deletions(-)