Fix PQsetvalue() to avoid possible crash when adding a new tuple.
PQsetvalue unnecessarily duplicated the logic in pqAddTuple, and didn't
duplicate it exactly either --- pqAddTuple does not care what is in the
tuple-pointer array positions beyond the last valid entry, whereas the
code in PQsetvalue assumed such positions would contain NULL. This led
to possible crashes if PQsetvalue was applied to a PGresult that had
previously been enlarged with pqAddTuple, for instance one built from a
server query. Fix by relying on pqAddTuple instead of duplicating logic,
and not assuming anything about the contents of res->tuples[res->ntups].
Back-patch to 8.4, where PQsetvalue was introduced.
Andrew Chernow
Branch
------
REL8_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/e06d1a88f3003bbff96ba052e5ba2366265db623
Modified Files
--------------
src/interfaces/libpq/fe-exec.c | 27 ++++-----------------------
1 files changed, 4 insertions(+), 23 deletions(-)