Обсуждение: pgsql: Update warning about synchronous-commit durability, per suggesti

Поиск
Список
Период
Сортировка

pgsql: Update warning about synchronous-commit durability, per suggesti

От
Bruce Momjian
Дата:
Update warning about synchronous-commit durability, per suggestion from
Robvert Haas.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=a91c950658016162020258574fb98aba182a5eac

Modified Files
--------------
doc/src/sgml/perform.sgml |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


Re: pgsql: Update warning about synchronous-commit durability, per suggesti

От
Robert Haas
Дата:
On Tue, Jan 25, 2011 at 8:32 PM, Bruce Momjian <bruce@momjian.us> wrote:
> Update warning about synchronous-commit durability, per suggestion from
> Robvert Haas.

The revised text is just as silly as the original text.  The point is
that with fsync turned off, the *entire database* is toast after a
crash.  You don't need to give any special warning for
synchronous_commit above and beyond what applies to the whole section.
 Just delete that part.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgsql: Update warning about synchronous-commit durability, per suggesti

От
Bruce Momjian
Дата:
Robert Haas wrote:
> On Tue, Jan 25, 2011 at 8:32 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > Update warning about synchronous-commit durability, per suggestion from
> > Robvert Haas.
>
> The revised text is just as silly as the original text.  The point is
> that with fsync turned off, the *entire database* is toast after a
> crash.  You don't need to give any special warning for
> synchronous_commit above and beyond what applies to the whole section.
>  Just delete that part.

I understand now.  Doc patch attached and committed.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +
diff --git a/doc/src/sgml/perform.sgml b/doc/src/sgml/perform.sgml
index fb55598..0a10457 100644
*** a/doc/src/sgml/perform.sgml
--- b/doc/src/sgml/perform.sgml
*************** SELECT * FROM x, y, a, b, c WHERE someth
*** 1157,1165 ****

       <listitem>
        <para>
!        Turn off <xref linkend="guc-synchronous-commit">;  there might be no
         need to write the <acronym>WAL</acronym> to disk on every
!        commit.  This can cause transaction loss after a server crash.
        </para>
       </listitem>
      </itemizedlist>
--- 1157,1165 ----

       <listitem>
        <para>
!        Turn off <xref linkend="guc-synchronous-commit">;  there is no
         need to write the <acronym>WAL</acronym> to disk on every
!        commit.
        </para>
       </listitem>
      </itemizedlist>