Обсуждение: pgsql: Reset 'ps' display just once when resolving VXID conflicts.

Поиск
Список
Период
Сортировка

pgsql: Reset 'ps' display just once when resolving VXID conflicts.

От
Robert Haas
Дата:
Reset 'ps' display just once when resolving VXID conflicts.

This prevents the word "waiting" from briefly disappearing from the ps
status line when ResolveRecoveryConflictWithVirtualXIDs begins a new
iteration of the outer loop.

Along the way, remove some useless pgstat_report_waiting() calls;
the startup process doesn't appear in pg_stat_activity.

Fujii Masao

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=611fed371227f430e71d0ff7fed037f1006b410d

Modified Files
--------------
src/backend/storage/ipc/standby.c |   30 +++++++++++++-----------------
1 files changed, 13 insertions(+), 17 deletions(-)


Re: pgsql: Reset 'ps' display just once when resolving VXID conflicts.

От
Tom Lane
Дата:
Robert Haas <rhaas@postgresql.org> writes:
> Reset 'ps' display just once when resolving VXID conflicts.
> This prevents the word "waiting" from briefly disappearing from the ps
> status line when ResolveRecoveryConflictWithVirtualXIDs begins a new
> iteration of the outer loop.

I imagine the reason for the original coding was to avoid a useless
gettimeofday kernel call in the common case that there are no
conflicting xacts to wait for.  Could we restore that behavior?

            regards, tom lane