Обсуждение: pgsql: And another one
Log Message: ----------- And another one Modified Files: -------------- pgsql/src/interfaces/ecpg/include: pgtypes_numeric.h (r1.16 -> r1.17) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/include/pgtypes_numeric.h?r1=1.16&r2=1.17) pgsql/src/interfaces/ecpg/test/expected: compat_informix-sqlda.c (r1.7 -> r1.8) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c?r1=1.7&r2=1.8) sql-sqlda.c (r1.7 -> r1.8) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/sql-sqlda.c?r1=1.7&r2=1.8)
This kind of commit message is pretty much useless. If you want to do a git blame/cvs annotate/whatever later, it gives exactly zero information. Isn't it better to just reuse the previous commit message? That will also allow tools to group the commits together (if you're lucky, they might even show up in git as a single commit) (if you actually need this many different commits, of course :P) //Magnus On Tue, Jan 5, 2010 at 18:10, Michael Meskes <meskes@postgresql.org> wrote: > Log Message: > ----------- > And another one > > Modified Files: > -------------- > pgsql/src/interfaces/ecpg/include: > pgtypes_numeric.h (r1.16 -> r1.17) > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/include/pgtypes_numeric.h?r1=1.16&r2=1.17) > pgsql/src/interfaces/ecpg/test/expected: > compat_informix-sqlda.c (r1.7 -> r1.8) > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c?r1=1.7&r2=1.8) > sql-sqlda.c (r1.7 -> r1.8) > (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/test/expected/sql-sqlda.c?r1=1.7&r2=1.8) > > -- > Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-committers > -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
On Tue, Jan 05, 2010 at 06:20:07PM +0100, Magnus Hagander wrote: > This kind of commit message is pretty much useless. If you want to do > a git blame/cvs annotate/whatever later, it gives exactly zero > information. No, I didn't want to blame anything. I was just trying to fix this before leaving as I had to pick up one of my sons. And no, this didn't show up in any of my tests as obviously the files were rewritten by cvs when committed. After using git so much the fault was in front of my keyboard because I simply forgot about this feature. > Isn't it better to just reuse the previous commit message? That will > also allow tools to group the commits together (if you're lucky, they > might even show up in git as a single commit) Is there anything in cvs comparable to the git amend option? > (if you actually need this many different commits, of course :P) Need? No way, it just happens sometimes. Sigh. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: meskes@jabber.org VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL
On Wed, Jan 6, 2010 at 10:48, Michael Meskes <meskes@postgresql.org> wrote: > On Tue, Jan 05, 2010 at 06:20:07PM +0100, Magnus Hagander wrote: >> This kind of commit message is pretty much useless. If you want to do >> a git blame/cvs annotate/whatever later, it gives exactly zero >> information. > > No, I didn't want to blame anything. I was just trying to fix this before > leaving as I had to pick up one of my sons. And no, this didn't show up in any > of my tests as obviously the files were rewritten by cvs when committed. After > using git so much the fault was in front of my keyboard because I simply forgot > about this feature. I think you misunderstand what I mean with blame in this case.. I mean the command "git blame". Which is basically the same as "cvs annotate". Which now just shows that the reason the change was made was "And another one". Which says nothing. So you have to go back out and figure out which was the commit that actually contains the information that you're looking for. I totally understand that this happens, I'm just arguing for a commit message that will make life easier in the future :-) >> Isn't it better to just reuse the previous commit message? That will >> also allow tools to group the commits together (if you're lucky, they >> might even show up in git as a single commit) > > Is there anything in cvs comparable to the git amend option? No :-( -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/