Обсуждение: pgsql: Append major version number and for libraries soname major
pgsql: Append major version number and for libraries soname major
От
petere@postgresql.org (Peter Eisentraut)
Дата:
Log Message:
-----------
Append major version number and for libraries soname major version number
to the gettext domain name, to simplify parallel installations.
Also, rename set_text_domain() to pg_bindtextdomain(), because that is what
it does.
Modified Files:
--------------
pgsql:
configure (r1.616 -> r1.617)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/configure?r1=1.616&r2=1.617)
configure.in (r1.576 -> r1.577)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/configure.in?r1=1.576&r2=1.577)
pgsql/doc/src/sgml:
Makefile (r1.113 -> r1.114)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/Makefile?r1=1.113&r2=1.114)
pgsql/src:
Makefile.global.in (r1.248 -> r1.249)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.global.in?r1=1.248&r2=1.249)
Makefile.shlib (r1.118 -> r1.119)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/Makefile.shlib?r1=1.118&r2=1.119)
nls-global.mk (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/nls-global.mk?r1=1.14&r2=1.15)
pgsql/src/backend/main:
main.c (r1.110 -> r1.111)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/main/main.c?r1=1.110&r2=1.111)
pgsql/src/backend/utils/init:
miscinit.c (r1.168 -> r1.169)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/init/miscinit.c?r1=1.168&r2=1.169)
pgsql/src/bin/initdb:
initdb.c (r1.164 -> r1.165)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/initdb/initdb.c?r1=1.164&r2=1.165)
pgsql/src/bin/pg_config:
pg_config.c (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_config/pg_config.c?r1=1.28&r2=1.29)
pgsql/src/bin/pg_controldata:
pg_controldata.c (r1.41 -> r1.42)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_controldata/pg_controldata.c?r1=1.41&r2=1.42)
pgsql/src/bin/pg_ctl:
pg_ctl.c (r1.104 -> r1.105)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_ctl/pg_ctl.c?r1=1.104&r2=1.105)
pgsql/src/bin/pg_dump:
pg_dump.c (r1.506 -> r1.507)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.506&r2=1.507)
pg_dumpall.c (r1.108 -> r1.109)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dumpall.c?r1=1.108&r2=1.109)
pg_restore.c (r1.88 -> r1.89)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_restore.c?r1=1.88&r2=1.89)
pgsql/src/bin/pg_resetxlog:
pg_resetxlog.c (r1.69 -> r1.70)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_resetxlog/pg_resetxlog.c?r1=1.69&r2=1.70)
pgsql/src/bin/psql:
startup.c (r1.151 -> r1.152)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/startup.c?r1=1.151&r2=1.152)
pgsql/src/bin/scripts:
clusterdb.c (r1.21 -> r1.22)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/clusterdb.c?r1=1.21&r2=1.22)
createdb.c (r1.28 -> r1.29)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/createdb.c?r1=1.28&r2=1.29)
createlang.c (r1.30 -> r1.31)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/createlang.c?r1=1.30&r2=1.31)
createuser.c (r1.38 -> r1.39)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/createuser.c?r1=1.38&r2=1.39)
dropdb.c (r1.22 -> r1.23)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/dropdb.c?r1=1.22&r2=1.23)
droplang.c (r1.27 -> r1.28)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/droplang.c?r1=1.27&r2=1.28)
dropuser.c (r1.23 -> r1.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/dropuser.c?r1=1.23&r2=1.24)
reindexdb.c (r1.13 -> r1.14)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/reindexdb.c?r1=1.13&r2=1.14)
vacuumdb.c (r1.20 -> r1.21)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/scripts/vacuumdb.c?r1=1.20&r2=1.21)
pgsql/src/include:
c.h (r1.230 -> r1.231)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/c.h?r1=1.230&r2=1.231)
miscadmin.h (r1.205 -> r1.206)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/miscadmin.h?r1=1.205&r2=1.206)
pg_config.h.in (r1.135 -> r1.136)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/pg_config.h.in?r1=1.135&r2=1.136)
pgsql/src/interfaces/ecpg/ecpglib:
misc.c (r1.43 -> r1.44)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/ecpglib/misc.c?r1=1.43&r2=1.44)
pgsql/src/interfaces/ecpg/preproc:
ecpg.c (r1.105 -> r1.106)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/ecpg/preproc/ecpg.c?r1=1.105&r2=1.106)
pgsql/src/interfaces/libpq:
fe-misc.c (r1.136 -> r1.137)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-misc.c?r1=1.136&r2=1.137)
pgsql/src/pl/plperl:
plperl.c (r1.142 -> r1.143)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c?r1=1.142&r2=1.143)
pgsql/src/pl/plpgsql/src:
pl_handler.c (r1.41 -> r1.42)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/pl_handler.c?r1=1.41&r2=1.42)
plpgsql.h (r1.105 -> r1.106)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpgsql/src/plpgsql.h?r1=1.105&r2=1.106)
pgsql/src/pl/plpython:
plpython.c (r1.116 -> r1.117)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/plpython/plpython.c?r1=1.116&r2=1.117)
pgsql/src/pl/tcl:
pltcl.c (r1.123 -> r1.124)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/pl/tcl/pltcl.c?r1=1.123&r2=1.124)
pgsql/src/port:
exec.c (r1.60 -> r1.61)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/exec.c?r1=1.60&r2=1.61)
pgsql/src/test/regress:
pg_regress.c (r1.54 -> r1.55)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/pg_regress.c?r1=1.54&r2=1.55)
petere@postgresql.org (Peter Eisentraut) writes:
> Log Message:
> -----------
> Append major version number and for libraries soname major version number
> to the gettext domain name, to simplify parallel installations.
The results from buildfarm member red_bat suggest that this commit broke
the MSVC build. (I think that is the only MSVC buildfarm member that's
up at the moment.)
Build FAILED.
.\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
.\src\backend\main\main.c(90): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
.\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION'
0 Warning(s)
3 Error(s)
regards, tom lane
On Fri, Dec 12, 2008 at 12:41 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > petere@postgresql.org (Peter Eisentraut) writes: >> Log Message: >> ----------- >> Append major version number and for libraries soname major version number >> to the gettext domain name, to simplify parallel installations. > > The results from buildfarm member red_bat suggest that this commit broke > the MSVC build. (I think that is the only MSVC buildfarm member that's > up at the moment.) > > Build FAILED. > .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION' > .\src\backend\main\main.c(90): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION' > .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION' > 0 Warning(s) > 3 Error(s) Any eta on a fix for this? My internal builds are failing as well as red_bat. (and yes, the other 2 MSVC buildfarm members are currently waiting for Dell to get hold of a new motherboard for their box). -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page wrote: > On Fri, Dec 12, 2008 at 12:41 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> petere@postgresql.org (Peter Eisentraut) writes: >>> Log Message: >>> ----------- >>> Append major version number and for libraries soname major version number >>> to the gettext domain name, to simplify parallel installations. >> The results from buildfarm member red_bat suggest that this commit broke >> the MSVC build. (I think that is the only MSVC buildfarm member that's >> up at the moment.) >> >> Build FAILED. >> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION' >> .\src\backend\main\main.c(90): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION' >> .\src\port\exec.c(633): error C2146: syntax error : missing ')' before identifier 'PG_MAJORVERSION' >> 0 Warning(s) >> 3 Error(s) > > Any eta on a fix for this? My internal builds are failing as well as > red_bat. (and yes, the other 2 MSVC buildfarm members are currently > waiting for Dell to get hold of a new motherboard for their box). I think the maintenance of the MSVC build system is the job of the, well, maintainer of the MSVC build system, whoever that may be. In other words, I have no ETA for you from me. I'd be glad, however, to provide information to the maintainers. The fix here is to define PG_MAJORVERSION near whereever you define PG_VERSION, just make it look like "8.4" instead of "8.4devel".
Magnus? On Tue, Dec 16, 2008 at 10:47 AM, Peter Eisentraut <peter_e@gmx.net> wrote: > > I think the maintenance of the MSVC build system is the job of the, well, > maintainer of the MSVC build system, whoever that may be. In other words, I > have no ETA for you from me. I'd be glad, however, to provide information > to the maintainers. > > The fix here is to define PG_MAJORVERSION near whereever you define > PG_VERSION, just make it look like "8.4" instead of "8.4devel". > -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Peter Eisentraut <peter_e@gmx.net> writes:
> Dave Page wrote:
>> Any eta on a fix for this? My internal builds are failing as well as
>> red_bat. (and yes, the other 2 MSVC buildfarm members are currently
>> waiting for Dell to get hold of a new motherboard for their box).
> I think the maintenance of the MSVC build system is the job of the,
> well, maintainer of the MSVC build system, whoever that may be. In
> other words, I have no ETA for you from me. I'd be glad, however, to
> provide information to the maintainers.
I do not think this is an appropriate attitude for a committer to take.
You are responsible for what you commit. If you don't have the
knowledge to fix something, or the resources to test it, okay ... but
you then need to be proactive about getting someone else to fix/test it.
Or else revert the broken patch.
regards, tom lane
Tom Lane wrote: > Peter Eisentraut <peter_e@gmx.net> writes: > >> Dave Page wrote: >> >>> Any eta on a fix for this? My internal builds are failing as well as >>> red_bat. (and yes, the other 2 MSVC buildfarm members are currently >>> waiting for Dell to get hold of a new motherboard for their box). >>> > > >> I think the maintenance of the MSVC build system is the job of the, >> well, maintainer of the MSVC build system, whoever that may be. In >> other words, I have no ETA for you from me. I'd be glad, however, to >> provide information to the maintainers. >> > > I do not think this is an appropriate attitude for a committer to take. > You are responsible for what you commit. If you don't have the > knowledge to fix something, or the resources to test it, okay ... but > you then need to be proactive about getting someone else to fix/test it. > Or else revert the broken patch. > > > I agree. I have committed an attempted fix which I discussed briefly with Magnus. cheers andrew