Обсуждение: pgsql: Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by

Log Message:
-----------
Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by treating the
init options of the template as top-level options in the syntax.  This also
makes ALTER a bit easier to use, since options can be replaced individually.
I also made these statements verify that the tmplinit method will accept
the new settings before they get stored; in the original coding you didn't
find out about mistakes until the dictionary got invoked.

Under the hood, init methods now get options as a List of DefElem instead
of a raw text string --- that lets tsearch use existing options-pushing code
instead of duplicating functionality.

Modified Files:
--------------
    pgsql/doc/src/sgml/ref:
        alter_tsdictionary.sgml (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/alter_tsdictionary.sgml?r1=1.1&r2=1.2)
        create_tsdictionary.sgml (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/ref/create_tsdictionary.sgml?r1=1.1&r2=1.2)
    pgsql/src/backend/commands:
        tsearchcmds.c (r1.2 -> r1.3)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tsearchcmds.c?r1=1.2&r2=1.3)
    pgsql/src/backend/snowball:
        dict_snowball.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/snowball/dict_snowball.c?r1=1.1&r2=1.2)
        snowball.sql.in (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/snowball/snowball.sql.in?r1=1.1&r2=1.2)
    pgsql/src/backend/tsearch:
        dict_ispell.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/dict_ispell.c?r1=1.1&r2=1.2)
        dict_simple.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/dict_simple.c?r1=1.1&r2=1.2)
        dict_thesaurus.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/dict_thesaurus.c?r1=1.1&r2=1.2)
        ts_utils.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/ts_utils.c?r1=1.1&r2=1.2)
        wparser.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/wparser.c?r1=1.1&r2=1.2)
        wparser_def.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tsearch/wparser_def.c?r1=1.1&r2=1.2)
    pgsql/src/backend/utils/cache:
        ts_cache.c (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/cache/ts_cache.c?r1=1.1&r2=1.2)
    pgsql/src/bin/pg_dump:
        pg_dump.c (r1.470 -> r1.471)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.470&r2=1.471)
    pgsql/src/include/catalog:
        catversion.h (r1.416 -> r1.417)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/catversion.h?r1=1.416&r2=1.417)
        pg_proc.h (r1.463 -> r1.464)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h?r1=1.463&r2=1.464)
    pgsql/src/include/commands:
        defrem.h (r1.83 -> r1.84)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/defrem.h?r1=1.83&r2=1.84)
    pgsql/src/include/tsearch:
        ts_public.h (r1.1 -> r1.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/tsearch/ts_public.h?r1=1.1&r2=1.2)

> the new settings before they get stored; in the original coding you didn't
> find out about mistakes until the dictionary got invoked.

That is source of initdb error with -E KOI8-R --locale ru_RU.KOI8-R options :
ERROR:  character 0xc3a5 of encoding "UTF8" has no equivalent in "KOI8"

Snowball dictionary tries to convert swedish (some languages too, but that was
first which I see) stopword file from UTF8 to KOI8 encoding.

--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/