Обсуждение: latest commit breaks tsearch2

query_gist.c: In function `sizebitvec':
query_gist.c:203: warning: control reaches end of non-void function

Looking at the code, gcc is right to complain --- if this is working for
you it's only accidental.  I don't much care for the hard-wired
assumption about the size of TPQTGist either ...

            regards, tom lane

> query_gist.c: In function `sizebitvec':
> query_gist.c:203: warning: control reaches end of non-void function
Fixed

>
> Looking at the code, gcc is right to complain --- if this is working for
> you it's only accidental.

It works because index tree was correct but was very far from optimal.


>  I don't much care for the hard-wired
> assumption about the size of TPQTGist either ...

typedef uint64 TPQTGist;

What is your doubt? You suggest to use  sizeof(TPQTGist)*BIT_PER_BYTE?


--
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Teodor Sigaev <teodor@sigaev.ru> writes:
>> I don't much care for the hard-wired
>> assumption about the size of TPQTGist either ...

> typedef uint64 TPQTGist;

> What is your doubt? You suggest to use  sizeof(TPQTGist)*BIT_PER_BYTE?

Yeah.  It'll make the code easier to adapt to a machine without any
native int64 type.

            regards, tom lane