Обсуждение: pgsql/src/backend/utils/adt like.c like_match.c

CVSROOT:    /cvsroot
Module name:    pgsql
Changes by:    ishii@postgresql.org    01/10/03 22:15:47

Modified files:
    src/backend/utils/adt: like.c
Added files:
    src/backend/utils/adt: like_match.c

Log message:
    Optimization for single byte encodings.

ishii@postgresql.org writes:
> Modified files:
>     src/backend/utils/adt: like.c
> Added files:
>     src/backend/utils/adt: like_match.c

> Log message:
>     Optimization for single byte encodings.

Hrrm ... I'd sort of expect to see a Makefile update in there ...

            regards, tom lane

> ishii@postgresql.org writes:
> > Modified files:
> >     src/backend/utils/adt: like.c
> > Added files:
> >     src/backend/utils/adt: like_match.c
>
> > Log message:
> >     Optimization for single byte encodings.
>
> Hrrm ... I'd sort of expect to see a Makefile update in there ...

Do you want this kind of depedency in Makefie?

   like.c: like_match.c
--
Tatsuo Ishii

Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> Do you want this kind of depedency in Makefie?

>    like.c: like_match.c

Shouldn't it be like.o to like_match.c?  Actually you probably need

    like.o: like.c like_match.c

to keep gmake from deriving the wrong default make rule ...

            regards, tom lane

> Shouldn't it be like.o to like_match.c?  Actually you probably need
>
>     like.o: like.c like_match.c
>
> to keep gmake from deriving the wrong default make rule ...

Done. Also I modified regex/Makefile to add the dependency for
regexec.c.
--
Tatsuo Ishii

Tom Lane writes:

> Tatsuo Ishii <t-ishii@sra.co.jp> writes:
> > Do you want this kind of depedency in Makefie?
>
> >    like.c: like_match.c
>
> Shouldn't it be like.o to like_match.c?

Technically yes, but since it's an #included file you don't need it at all
if all you want is to get it to compile.  For complete dependencies it's
--enable-depend and this one will be included automatically.

--
Peter Eisentraut   peter_e@gmx.net   http://funkturm.homeip.net/~peter

Peter Eisentraut <peter_e@gmx.net> writes:
>> Shouldn't it be like.o to like_match.c?

> Technically yes, but since it's an #included file you don't need it at all
> if all you want is to get it to compile.  For complete dependencies it's
> --enable-depend and this one will be included automatically.

Sure, but there are a few dependencies that seem important enough to
hard-wire into the Makefiles, so that they'll be honored even if you
don't do --enable-depend.  backend/parser has some, for example.
This one seemed to me to be of that ilk.  I expect to have to be careful
if I hack .h files without having enabled dependencies ... but one
normally doesn't need to think about that for .c files.

            regards, tom lane