Обсуждение: pgsql/src/backend/commands (view.c)
Date: Thursday, December 21, 2000 @ 12:36:15 Author: tgl Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/commands from hub.org:/home/projects/pgsql/tmp/cvs-serv64711 Modified Files: view.c ----------------------------- Log Message ----------------------------- Fix longstanding bug with VIEW using BETWEEN: OffsetVarNodes would get applied to the duplicated subtree twice. Probably someday we should fix the parser not to generate multiple links to the same subtree, but for now a quick copyObject() is the path of least resistance.
I think that was me, long ago. > Date: Thursday, December 21, 2000 @ 12:36:15 > Author: tgl > > Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/commands > from hub.org:/home/projects/pgsql/tmp/cvs-serv64711 > > Modified Files: > view.c > > ----------------------------- Log Message ----------------------------- > > Fix longstanding bug with VIEW using BETWEEN: OffsetVarNodes would get > applied to the duplicated subtree twice. Probably someday we should > fix the parser not to generate multiple links to the same subtree, > but for now a quick copyObject() is the path of least resistance. > > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Bruce Momjian <pgman@candle.pha.pa.us> writes: > I think that was me, long ago. IIRC, BETWEEN is not the only construct that generates multiply-linked subtrees, so you don't need to take the whole blame ;-) The copyObject solution has the advantage of being fairly robust, whereas trying to ban such things in the parser's output would not be. regards, tom lane
OK, I will remove the new TODO item. > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > I think that was me, long ago. > > IIRC, BETWEEN is not the only construct that generates multiply-linked > subtrees, so you don't need to take the whole blame ;-) > > The copyObject solution has the advantage of being fairly robust, > whereas trying to ban such things in the parser's output would not be. > > regards, tom lane > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026