Обсуждение: pgsql/src/backend/storage/smgr (smgr.c)

  Date: Monday, November 13, 2000 @ 04:06:36
Author: inoue

Update of /home/projects/pgsql/cvsroot/pgsql/src/backend/storage/smgr
     from hub.org:/tmp/cvs-serv92577/storage/smgr

Modified Files:
    smgr.c

-----------------------------  Log Message  -----------------------------

prevent open failure of VIEW

inoue@postgresql.org writes:
> prevent open failure of VIEW

I do not like this fix.  We should be moving away from having smgr
access relcache entries, not adding more relcache knowledge to it.
So checks for view-ness should be at a higher level.

What case were you seeing a failure in?

            regards, tom lane

Tom Lane wrote:

> inoue@postgresql.org writes:
> > prevent open failure of VIEW
>
> I do not like this fix.  We should be moving away from having smgr
> access relcache entries, not adding more relcache knowledge to it.
> So checks for view-ness should be at a higher level.
>
> What case were you seeing a failure in?
>

I see the failure in xlogutils.c.
Oops I'm mistaken,another is smgrnblocks call
in RelationGetNumberOfBlocks() and I didn't
change it at all.
I don't like this fix either and I intend to change
at higher level first. However it seems to me
that checking relkind every time is not only ugly
but also unreliable.

I don't stick to my change.
Please change as you prefer.

Regards.
Hiroshi Inoue