Обсуждение: Tab completion of function arguments not working in all cases

Hi,

I noticed this while testing 9.2, but it seems to go back to at least
8.3. Tab completion of function arguments doesn't work if the function
is schema-qualified or double-quoted. So for example,

  DROP FUNCTION my_function ( <TAB>

completes the functions arguments, but

  DROP FUNCTION my_schema.my_function ( <TAB>

doesn't offer any completions, and nor does

  DROP FUNCTION "my function" ( <TAB>


The attached patch fixes these problems by introducing a new macro
COMPLETE_WITH_ARG, similar to the existing COMPLETE_WITH_ATTR, which
seems to be the nearest analogous code that covers all the edge cases.

Regards,
Dean

On Sat, Jun 9, 2012 at 2:40 AM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:

> I noticed this while testing 9.2, but it seems to go back to at least
> 8.3. Tab completion of function arguments doesn't work if the function
> is schema-qualified or double-quoted. So for example,

Good idea, would you like to submit for the open CF?

Josh

On 12 June 2012 21:27, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> On Sat, Jun 9, 2012 at 2:40 AM, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
>> I noticed this while testing 9.2, but it seems to go back to at least
>> 8.3. Tab completion of function arguments doesn't work if the function
>> is schema-qualified or double-quoted. So for example,
>
> Good idea, would you like to submit for the open CF?
>

Hmm, I was thinking of this as a bug because I found it during beta
testing, but on reflection I guess that it's more of an annoying
limitation than a bug per se. Also since no one appears to have
noticed until now, I guess it's not worth back-patching, so I'll
submit it for 9.3.

Regards,
Dean