Обсуждение: BUG #6343: PGTYPES library missing qualifiers

Поиск
Список
Период
Сортировка

BUG #6343: PGTYPES library missing qualifiers

От
kojiro@hello-channel.com
Дата:
The following bug has been logged on the website:

Bug reference:      6343
Logged by:          Daniel Loffgren
Email address:      kojiro@hello-channel.com
PostgreSQL version: 9.1.1
Operating system:   NetBSD
Description:=20=20=20=20=20=20=20=20

In the ecpg PGTYPES library, there are functions like this:=20

extern int PGTYPEStimestamp_fmt_asc(timestamp *, char *, int, char *);

The last argument is the formatting string, yet isn't constant. This
generates warnings/errors on many compilers that are watching for discarding
of qualifiers when passing in string literals. It's a simple fix, although I
noticed that in PGTYPEStimestamp_defmt_asc the code is altering the
formatter if it is null, which prevents making the formatter const. However,
dttofmtasc_replace does not alter the formatter, and so should not pose a
problem for PGTYPEStimestamp_fmt_asc which passes straight to it.

Re: BUG #6343: PGTYPES library missing qualifiers

От
Michael Meskes
Дата:
On Fri, Dec 16, 2011 at 03:33:18PM +0000, kojiro@hello-channel.com wrote:
> The last argument is the formatting string, yet isn't constant. This
> generates warnings/errors on many compilers that are watching for discard=
ing
> of qualifiers when passing in string literals. It's a simple fix, althoug=
h I
> ...

Changed in our master branch. Thanks for bringing this up.

Michael
--=20
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at googlemail dot com
VfL Borussia! For=C3=A7a Bar=C3=A7a! Go SF 49ers! Use Debian GNU/Linux, Pos=
tgreSQL