Обсуждение: src/tools/fsync/test_fsync.c does not compile

The discussion on -performance about disk caching reminded me that the
useful fsync test utility does not seem to compile (git master on Ubuntu
10.04):

$ make
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
-fwrapv -g -I../../../src/interfaces/libpq -I../../../src/include
-D_GNU_SOURCE -c -o test_fsync.o test_fsync.c
In file included from /usr/include/fcntl.h:205,
from ../../../src/include/access/xlogdefs.h:15,
from ../../../src/include/access/xlog.h:15,
from ../../../src/include/access/xlog_internal.h:19,
from test_fsync.c:11:
In function ‘open’,
inlined from ‘main’ at test_fsync.c:66:
/usr/include/bits/fcntl2.h:45: error: call to ‘__open_too_many_args’
declared with attribute error: open can be called either with 2 or 3
arguments, not more
make: *** [test_fsync.o] Error 1

The tiny change (attached) seems it fix it for me.

regards

Mark

Mark Kirkwood <mark.kirkwood@catalyst.net.nz> writes:
> In function ‘open’,
> inlined from ‘main’ at test_fsync.c:66:
> /usr/include/bits/fcntl2.h:45: error: call to ‘__open_too_many_args’
> declared with attribute error: open can be called either with 2 or 3
> arguments, not more

Interesting --- it's certainly wrong, but I don't see that complaint
here (on Fedora 13).

> The tiny change (attached) seems it fix it for me.

Agreed, this is a bug fix.  Applied.

            regards, tom lane