Обсуждение: Git Makefile.am
Hi, Git head Makefile.am line .76 should be: AM_CPPFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -I$(top_srcdir)/pgadmin/include $(__CPPFLAGS) $(__EDB_LIBPQ) Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia
On Tue, Mar 8, 2011 at 10:23 PM, Vladimir Kokovic <vladimir.kokovic@gmail.com> wrote: > Hi, > > Git head Makefile.am line .76 should be: > > AM_CPPFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" > -I$(top_srcdir)/pgadmin/include $(__CPPFLAGS) $(__EDB_LIBPQ) That's exactly what it is on my copy. What do you see? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
[Please keep the list CC'd] On Tue, Mar 8, 2011 at 11:56 PM, Vladimir Kokovic <vladimir.kokovic@gmail.com> wrote: > Sorry Dave, > > Line is 105: > > BUILT_SOURCES = $(patsubst %.png,%.pngc,$(wildcard > $(top_srcdir)/pgadmin/include/images/*.png) Hmm, vim is also highlighting that line as if it's an error, but the suggested change would leave an unmatched bracket. Why is that correct? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Hi, Git pgadmin/Makefile.am line .105 should be: BUILT_SOURCES = $(patsubst %.png,%.pngc,$(wildcard $(top_srcdir)/pgadmin/include/images/*.png)) Best regards, Vladimir Kokovic, DP senior, Belgrade, Serbia On 3/9/11, Dave Page <dpage@pgadmin.org> wrote: > [Please keep the list CC'd] > > On Tue, Mar 8, 2011 at 11:56 PM, Vladimir Kokovic > <vladimir.kokovic@gmail.com> wrote: >> Sorry Dave, >> >> Line is 105: >> >> BUILT_SOURCES = $(patsubst %.png,%.pngc,$(wildcard >> $(top_srcdir)/pgadmin/include/images/*.png) > > Hmm, vim is also highlighting that line as if it's an error, but the > suggested change would leave an unmatched bracket. Why is that > correct? > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
On Sat, Mar 12, 2011 at 3:19 PM, Vladimir Kokovic <vladimir.kokovic@gmail.com> wrote: > Hi, > > Git pgadmin/Makefile.am line .105 should be: > > BUILT_SOURCES = $(patsubst %.png,%.pngc,$(wildcard > $(top_srcdir)/pgadmin/include/images/*.png)) Good catch - patch committed. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company