Обсуждение: Two issues

Поиск
Список
Период
Сортировка

Two issues

От
Raymond O'Donnell
Дата:
Hi all,

Two things I've noticed in PgAdmin 1.10 (I'm on Windows XP Pro):

(i) When adding a new column to an existing table, the "Comment" text
area of the "New column..." dialog box is disabled.

(ii) If I view the data in a table, and then try two delete two or more
rows, it always asks me, "Are you sure you wish to delete the 12037568
selected rows?". If I select just one row, it correctly says "...the
selected row?".

Thanks,

Ray.

------------------------------------------------------------------
Raymond O'Donnell, Director of Music, Galway Cathedral, Ireland
rod@iol.ie
Galway Cathedral Recitals: http://www.galwaycathedral.org/recitals
------------------------------------------------------------------


Re: Two issues

От
Guillaume Lelarge
Дата:
Hi,

Le jeudi 6 août 2009 à 16:27:07, Raymond O'Donnell a écrit :
> [...]
> Two things I've noticed in PgAdmin 1.10 (I'm on Windows XP Pro):
>
> (i) When adding a new column to an existing table, the "Comment" text
> area of the "New column..." dialog box is disabled.
>

Yes, the code disables it at creation time, and enables it at modification
time.

> (ii) If I view the data in a table, and then try two delete two or more
> rows, it always asks me, "Are you sure you wish to delete the 12037568
> selected rows?". If I select just one row, it correctly says "...the
> selected row?".
>

This one has been fixed this morning by Magnus.


--
Guillaume.http://www.postgresqlfr.orghttp://dalibo.com


Re: Two issues

От
Guillaume Lelarge
Дата:
Le jeudi 6 août 2009 à 16:40:30, Guillaume Lelarge a écrit :
> Hi,
>
> Le jeudi 6 août 2009 à 16:27:07, Raymond O'Donnell a écrit :
> > [...]
> > Two things I've noticed in PgAdmin 1.10 (I'm on Windows XP Pro):
> >
> > (i) When adding a new column to an existing table, the "Comment" text
> > area of the "New column..." dialog box is disabled.
>
> Yes, the code disables it at creation time, and enables it at modification
> time.
>

I've been thinking about this. I think the reason why it is disabled at
creation is that this dialog can be called from two place: alone or within the
table dialog.

Moreover, Dave wants (wanted?) to work on the table creation dialog to make it
simpler to add columns. This should fix your issue.


--
Guillaume.http://www.postgresqlfr.orghttp://dalibo.com


Re: Two issues

От
Dave Page
Дата:
On Fri, Aug 7, 2009 at 4:36 PM, Guillaume Lelarge<guillaume@lelarge.info> wrote:
> Le jeudi 6 août 2009 à 16:40:30, Guillaume Lelarge a écrit :
>> Hi,
>>
>> Le jeudi 6 août 2009 à 16:27:07, Raymond O'Donnell a écrit :
>> > [...]
>> > Two things I've noticed in PgAdmin 1.10 (I'm on Windows XP Pro):
>> >
>> > (i) When adding a new column to an existing table, the "Comment" text
>> > area of the "New column..." dialog box is disabled.
>>
>> Yes, the code disables it at creation time, and enables it at modification
>> time.
>>
>
> I've been thinking about this. I think the reason why it is disabled at
> creation is that this dialog can be called from two place: alone or within the
> table dialog.

Yeah - it would be quite an invasive patch to fix that.

> Moreover, Dave wants (wanted?) to work on the table creation dialog to make it
> simpler to add columns. This should fix your issue.

Sachin@EDB is working on a new table dialogue in his spare cycles -
the aim is to get rid of all the sub-dialogues, when working on a
table (they'll still be there if you right-click an object in the tree
though - just no more popping up new dialogues to add a column to your
new table definition).

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com


Re: Two issues

От
Raymond O'Donnell
Дата:
On 07/08/2009 16:53, Dave Page wrote:
> On Fri, Aug 7, 2009 at 4:36 PM, Guillaume Lelarge<guillaume@lelarge.info> wrote:
>> Le jeudi 6 août 2009 à 16:40:30, Guillaume Lelarge a écrit :
>>> Hi,
>>>
>>> Le jeudi 6 août 2009 à 16:27:07, Raymond O'Donnell a écrit :
>>>> [...]
>>>> Two things I've noticed in PgAdmin 1.10 (I'm on Windows XP Pro):
>>>>
>>>> (i) When adding a new column to an existing table, the "Comment" text
>>>> area of the "New column..." dialog box is disabled.
>>> Yes, the code disables it at creation time, and enables it at modification
>>> time.
>>>
>> I've been thinking about this. I think the reason why it is disabled at
>> creation is that this dialog can be called from two place: alone or within the
>> table dialog.
> 
> Yeah - it would be quite an invasive patch to fix that.
> 
>> Moreover, Dave wants (wanted?) to work on the table creation dialog to make it
>> simpler to add columns. This should fix your issue.
> 
> Sachin@EDB is working on a new table dialogue in his spare cycles -
> the aim is to get rid of all the sub-dialogues, when working on a
> table (they'll still be there if you right-click an object in the tree
> though - just no more popping up new dialogues to add a column to your
> new table definition).

Sounds good - look forward to it.

Ray.


------------------------------------------------------------------
Raymond O'Donnell, Director of Music, Galway Cathedral, Ireland
rod@iol.ie
Galway Cathedral Recitals: http://www.galwaycathedral.org/recitals
------------------------------------------------------------------