Обсуждение: crash in FC2

Hi,

I am having some strange behavior in Fedora Core 2. I compiled a cvs
version, checked out today 16 september. When I try to add a new table,
or database, etc, pgadmin3 crash without any notice or warning, without
logging anything.

A new bug ?. 

Diego.

Diego A. Gil wrote:
> Hi,
>
> I am having some strange behavior in Fedora Core 2. I compiled a cvs
> version, checked out today 16 september. When I try to add a new table,
> or database, etc, pgadmin3 crash without any notice or warning, without
> logging anything.
>
> A new bug ?.

It's a side effect of the fix for the FindFocus bug. The crash you
describe happened to me, too. Try the attached patch (not sure if that's
the right fix, but it works for me.)

i.

--- src/ui/frmMain.cpp.old    Wed Sep 15 09:51:54 2004
+++ src/ui/frmMain.cpp    Wed Sep 15 13:44:27 2004
@@ -509,6 +509,8 @@
     if (data->IsCollection())
     {
         wxWindow *win=wxWindow::FindFocus();
+        if (!win)
+        return data;
         if (win == listViews)
         {
             if (listViews->GetSelection())

Thank you!. I applied this patch and worked.

It will be commited to cvs tree ?.


Diego.

El jue, 16-09-2004 a las 05:44, Ivan Nejgebauer escribió:
> Diego A. Gil wrote:
> > Hi,
> >
> > I am having some strange behavior in Fedora Core 2. I compiled a cvs
> > version, checked out today 16 september. When I try to add a new table,
> > or database, etc, pgadmin3 crash without any notice or warning, without
> > logging anything.
> >
> > A new bug ?.
>
> It's a side effect of the fix for the FindFocus bug. The crash you
> describe happened to me, too. Try the attached patch (not sure if that's
> the right fix, but it works for me.)
>
> i.
>
>
> ______________________________________________________________________
> --- src/ui/frmMain.cpp.old    Wed Sep 15 09:51:54 2004
> +++ src/ui/frmMain.cpp    Wed Sep 15 13:44:27 2004
> @@ -509,6 +509,8 @@
>      if (data->IsCollection())
>      {
>          wxWindow *win=wxWindow::FindFocus();
> +        if (!win)
> +        return data;
>          if (win == listViews)
>          {
>              if (listViews->GetSelection())
>
> ______________________________________________________________________
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faqs/FAQ.html

Ivan Nejgebauer wrote:
> Diego A. Gil wrote:
> 
>> Hi,
>>
>> I am having some strange behavior in Fedora Core 2. I compiled a cvs
>> version, checked out today 16 september. When I try to add a new table,
>> or database, etc, pgadmin3 crash without any notice or warning, without
>> logging anything.
>>
>> A new bug ?. 
> 
> 
> It's a side effect of the fix for the FindFocus bug. The crash you 
> describe happened to me, too. Try the attached patch (not sure if that's 
> the right fix, but it works for me.)

I see the problem, but it's not a final fix; context menu on properties 
can't be handled. For sure, FindFocus may never return NULL (but it does 
:-(  )

Obviously, with current wx the current item can't be determined using 
FindFocus.

I committed the patch as workaround, real fix to follow.

Regards,
Andreas