Обсуждение: PATCH: Python2.6 compatibility fixes (pgAdmin4)
Hi,
PFA minor patch for Python2.6 compatibility with pgAdmin4.
Please review.
Regards,
Вложения
+++ Adding related RM.
RM#1636 & RM#1659
--
Regards,
On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA minor patch for Python2.6 compatibility with pgAdmin4.Please review.Regards,
Thanks, patch applied. On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > +++ Adding related RM. > > RM#1636 & RM#1659 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala > <murtuza.zabuawala@enterprisedb.com> wrote: >> >> Hi, >> >> PFA minor patch for Python2.6 compatibility with pgAdmin4. >> Please review. >> >> >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Please find attached patch with following fix:
1) While running pgAdmin4 with latest git pull on Windows x64 environment, I got an exception on terminal console,
NameError
NameError: global name 'arch_keys' is not defined
Issue: arch_keys was defined inside the method add_server, but used outside the method.
I have handled this issue in attached patch.
On Tue, Sep 6, 2016 at 6:52 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.
On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala--<murtuza.zabuawala@enterprisedb.com> wrote:
> +++ Adding related RM.
>
> RM#1636 & RM#1659
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> PFA minor patch for Python2.6 compatibility with pgAdmin4.
>> Please review.
>>
>>
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Вложения
Thanks, applied. On Fri, Sep 9, 2016 at 1:53 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Please find attached patch with following fix: > > 1) While running pgAdmin4 with latest git pull on Windows x64 environment, I > got an exception on terminal console, >> >> NameError >> NameError: global name 'arch_keys' is not defined > > > Issue: arch_keys was defined inside the method add_server, but used outside > the method. > > I have handled this issue in attached patch. > > On Tue, Sep 6, 2016 at 6:52 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Thanks, patch applied. >> >> On Tue, Sep 6, 2016 at 12:08 PM, Murtuza Zabuawala >> <murtuza.zabuawala@enterprisedb.com> wrote: >> > +++ Adding related RM. >> > >> > RM#1636 & RM#1659 >> > >> > -- >> > Regards, >> > Murtuza Zabuawala >> > EnterpriseDB: http://www.enterprisedb.com >> > The Enterprise PostgreSQL Company >> > >> > On Tue, Sep 6, 2016 at 4:36 PM, Murtuza Zabuawala >> > <murtuza.zabuawala@enterprisedb.com> wrote: >> >> >> >> Hi, >> >> >> >> PFA minor patch for Python2.6 compatibility with pgAdmin4. >> >> Please review. >> >> >> >> >> >> Regards, >> >> Murtuza Zabuawala >> >> EnterpriseDB: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> > >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company