Обсуждение: PACTH: To fix the issue while selecting primary key in table (pgAdmin4)
Hi,
PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234.
--
Regards,
Вложения
Hi On Wed, Jun 22, 2016 at 12:56 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234. I've pushed the fix for 1234, however the fix for 1235 changes the control used in the grid to a checkbox which is inconsistent with the rest of the app where we use switches. Can that be changed? -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Re: PACTH: To fix the issue while selecting primary key in table (pgAdmin4)
От
Murtuza Zabuawala
Дата:
Hi Dave,
I have fixed the issue with Switch control, now it's working as expected along with DepsCell functionality.
PFA patch RM#1235 with Switch Cell.
While debugging the issue I have found typo in "index.js" which is also fixed with patch.
--
Regards,
On Thu, Jun 23, 2016 at 5:07 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi
On Wed, Jun 22, 2016 at 12:56 PM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234.
I've pushed the fix for 1234, however the fix for 1235 changes the
control used in the grid to a checkbox which is inconsistent with the
rest of the app where we use switches. Can that be changed?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks, applied. On Fri, Jun 24, 2016 at 11:20 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi Dave, > > I have fixed the issue with Switch control, now it's working as expected > along with DepsCell functionality. > > PFA patch RM#1235 with Switch Cell. > > While debugging the issue I have found typo in "index.js" which is also > fixed with patch. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Jun 23, 2016 at 5:07 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> Hi >> >> On Wed, Jun 22, 2016 at 12:56 PM, Murtuza Zabuawala >> <murtuza.zabuawala@enterprisedb.com> wrote: >> > Hi, >> > >> > PFA minor patches to fix two issues mentioned in RM#1235 & RM#1234. >> >> I've pushed the fix for 1234, however the fix for 1235 changes the >> control used in the grid to a checkbox which is inconsistent with the >> rest of the app where we use switches. Can that be changed? >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company