Обсуждение: PATCH: Fixed Textarea control template [pgAdmin4]
Hi,
PFA updated patch to fix an issue in textarea template, if we do not provide default rows then control then it fails to render it (issue with yesterday's Arun changes), Causing Sql-Feild Control to break which uses textarea to render code mirror control.
--
Regards,
Вложения
Hi,
PFA updated patch for mentioned issue.
--
Regards,
On Fri, Mar 11, 2016 at 1:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA updated patch to fix an issue in textarea template, if we do not provide default rows then control then it fails to render it (issue with yesterday's Arun changes), Causing Sql-Feild Control to break which uses textarea to render code mirror control.--Regards,
Вложения
On Fri, Mar 11, 2016 at 1:59 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,PFA updated patch for mentioned issue.
Can please you describe, why did you sent the updated path, what was missing in the previous patch?
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
--Regards,On Fri, Mar 11, 2016 at 1:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA updated patch to fix an issue in textarea template, if we do not provide default rows then control then it fails to render it (issue with yesterday's Arun changes), Causing Sql-Feild Control to break which uses textarea to render code mirror control.--Regards,
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Hi,
I have sent updated patch to include default rows arguments into sql field control.
Regards,
Murtuza
--
Regards,
On Fri, Mar 11, 2016 at 2:03 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Fri, Mar 11, 2016 at 1:59 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA updated patch for mentioned issue.Can please you describe, why did you sent the updated path, what was missing in the previous patch?--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
--Regards,On Fri, Mar 11, 2016 at 1:08 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,PFA updated patch to fix an issue in textarea template, if we do not provide default rows then control then it fails to render it (issue with yesterday's Arun changes), Causing Sql-Feild Control to break which uses textarea to render code mirror control.--Regards,
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Thanks, committed. On Fri, Mar 11, 2016 at 8:29 AM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA updated patch for mentioned issue. > > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Fri, Mar 11, 2016 at 1:08 PM, Murtuza Zabuawala > <murtuza.zabuawala@enterprisedb.com> wrote: >> >> Hi, >> >> PFA updated patch to fix an issue in textarea template, if we do not >> provide default rows then control then it fails to render it (issue with >> yesterday's Arun changes), Causing Sql-Feild Control to break which uses >> textarea to render code mirror control. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company