Обсуждение: Fix for complete-bundle.sh

Поиск
Список
Период
Сортировка

Fix for complete-bundle.sh

От
Sandeep Thakkar
Дата:
Hi

While building pgAdmin3 on OS X, we observed that the script complete-bundle.sh, greps for the string "Mach-O i386 executable" from the output of file command. This does not work on my OS X 10.8, where the file shows the output in a different order.

$ file pgAdmin3 
pgAdmin3: Mach-O executable i386

So, the grep fails there. Attached herewith is the patch that should work for "Mach-O i386 executable" and as well as "Mach-O executable i386" outputs.


--
Sandeep Thakkar

Вложения

Re: Fix for complete-bundle.sh

От
Dave Page
Дата:
Thanks - fix pushed.

On Thu, Nov 20, 2014 at 11:21 AM, Sandeep Thakkar
<sandeep.thakkar@enterprisedb.com> wrote:
> Hi
>
> While building pgAdmin3 on OS X, we observed that the script
> complete-bundle.sh, greps for the string "Mach-O i386 executable" from the
> output of file command. This does not work on my OS X 10.8, where the file
> shows the output in a different order.
>
> $ file pgAdmin3
> pgAdmin3: Mach-O executable i386
>
> So, the grep fails there. Attached herewith is the patch that should work
> for "Mach-O i386 executable" and as well as "Mach-O executable i386"
> outputs.
>
>
> --
> Sandeep Thakkar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company