Обсуждение: PATCH: saving macro after query pasting
Dave/Dmitriy,
I did not see any patch attached.
Did you forget to attach it?
On Wed, Jul 16, 2014 at 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:
Adding Ashesh :-)On Wed, Jul 16, 2014 at 9:07 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh - can you look at this ASAP please, and commit if it looks OK?--On Sat, Jul 12, 2014 at 12:06 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:Hello.
Please see this patch. These are changes in the macros manage dialog:
- the "Save" button is enabled after any change in the query window
- RestorePosition() in the constructor
- unnecessary variable appQueryModify has been removed
- changed the condition that checks whether the title and query were filled (method SetMacro())
Thank you.
--
Dmitriy Olshevskiy
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
PFA
On Wed, Jul 16, 2014 at 9:43 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Dave/Dmitriy,I did not see any patch attached.Did you forget to attach it?On Wed, Jul 16, 2014 at 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Ashesh :-)On Wed, Jul 16, 2014 at 9:07 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh - can you look at this ASAP please, and commit if it looks OK?--On Sat, Jul 12, 2014 at 12:06 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:Hello.
Please see this patch. These are changes in the macros manage dialog:
- the "Save" button is enabled after any change in the query window
- RestorePosition() in the constructor
- unnecessary variable appQueryModify has been removed
- changed the condition that checks whether the title and query were filled (method SetMacro())
Thank you.
--
Dmitriy Olshevskiy
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Вложения
Thanks.
I will look into it.
On Wed, Jul 16, 2014 at 2:26 PM, Dave Page <dpage@pgadmin.org> wrote:
PFAOn Wed, Jul 16, 2014 at 9:43 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Dave/Dmitriy,I did not see any patch attached.Did you forget to attach it?On Wed, Jul 16, 2014 at 1:38 PM, Dave Page <dpage@pgadmin.org> wrote:Adding Ashesh :-)On Wed, Jul 16, 2014 at 9:07 AM, Dave Page <dpage@pgadmin.org> wrote:Ashesh - can you look at this ASAP please, and commit if it looks OK?--On Sat, Jul 12, 2014 at 12:06 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:Hello.
Please see this patch. These are changes in the macros manage dialog:
- the "Save" button is enabled after any change in the query window
- RestorePosition() in the constructor
- unnecessary variable appQueryModify has been removed
- changed the condition that checks whether the title and query were filled (method SetMacro())
Thank you.
--
Dmitriy Olshevskiy
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Looks good to me.
Checked-in!
On Wed, Jul 16, 2014 at 1:37 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh - can you look at this ASAP please, and commit if it looks OK?On Sat, Jul 12, 2014 at 12:06 PM, Dmitriy Olshevskiy <olshevskiy87@bk.ru> wrote:Hello.
Please see this patch. These are changes in the macros manage dialog:
- the "Save" button is enabled after any change in the query window
- RestorePosition() in the constructor
- unnecessary variable appQueryModify has been removed
- changed the condition that checks whether the title and query were filled (method SetMacro())
Thank you.
--
Dmitriy Olshevskiy--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company