Обсуждение: Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

Поиск
Список
Период
Сортировка

Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

От
Sachin Srivastava
Дата:
Hi all,

Sub-Menu name "Disconnect" is same for disconnectDatabaseFactory and disconnectServerFactory.

Attached patch fixes the issue. I have kept the shortcut key same because both Menu options can never be enable at the same time.

--
Regards,
Sachin Srivastava
EnterpriseDB, India
Вложения

Re: Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

От
Dave Page
Дата:
Hi

Do both options ever show up on the same menu together?

On Tue, Aug 28, 2012 at 1:22 PM, Sachin Srivastava
<sachin.srivastava@enterprisedb.com> wrote:
> Hi all,
>
> Sub-Menu name "Disconnect" is same for disconnectDatabaseFactory and
> disconnectServerFactory.
>
> Attached patch fixes the issue. I have kept the shortcut key same because
> both Menu options can never be enable at the same time.
>
> --
> Regards,
> Sachin Srivastava
> EnterpriseDB, India
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

От
Sachin Srivastava
Дата:
Yes. See attached..

On Tue, Aug 28, 2012 at 6:09 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Do both options ever show up on the same menu together?

On Tue, Aug 28, 2012 at 1:22 PM, Sachin Srivastava
<sachin.srivastava@enterprisedb.com> wrote:
> Hi all,
>
> Sub-Menu name "Disconnect" is same for disconnectDatabaseFactory and
> disconnectServerFactory.
>
> Attached patch fixes the issue. I have kept the shortcut key same because
> both Menu options can never be enable at the same time.
>
> --
> Regards,
> Sachin Srivastava
> EnterpriseDB, India
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Regards,
Sachin Srivastava
EnterpriseDB, India
Вложения

Re: Same sub-menu name for disconnectDatabaseFactory and disconnectServerFactory.

От
Dave Page
Дата:
Thanks, patch applied (though, I lower-cased the second words for
consistency with most of the rest of the options). Guillaume, please
note - this affects translations.

We should review all these options in the future, and ensure we use
standardised capitalisation.

On Tue, Aug 28, 2012 at 1:51 PM, Sachin Srivastava
<sachin.srivastava@enterprisedb.com> wrote:
> Yes. See attached..
>
>
> On Tue, Aug 28, 2012 at 6:09 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> Do both options ever show up on the same menu together?
>>
>> On Tue, Aug 28, 2012 at 1:22 PM, Sachin Srivastava
>> <sachin.srivastava@enterprisedb.com> wrote:
>> > Hi all,
>> >
>> > Sub-Menu name "Disconnect" is same for disconnectDatabaseFactory and
>> > disconnectServerFactory.
>> >
>> > Attached patch fixes the issue. I have kept the shortcut key same
>> > because
>> > both Menu options can never be enable at the same time.
>> >
>> > --
>> > Regards,
>> > Sachin Srivastava
>> > EnterpriseDB, India
>> >
>> >
>> > --
>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
>
>
> --
> Regards,
> Sachin Srivastava
> EnterpriseDB, India



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company