Обсуждение: Query tool column headers
Attached patch changes the column headers in the query tool to put <> aronud the datatype. While it's already on a separate line, this makes it more clear which part is the datatype and which part is the name of the column, making parsing easier on the eye when names and datatypes are close to each other. I looked for a way to make it italic or so instead, but it appears wxWidgets doesn't support that - it can only set the formatting for the whole header, which includes both the name and the datatype. Objections? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
Вложения
On Wed, Jun 27, 2012 at 3:53 PM, Magnus Hagander <magnus@hagander.net> wrote: > Attached patch changes the column headers in the query tool to put <> > aronud the datatype. While it's already on a separate line, this makes > it more clear which part is the datatype and which part is the name of > the column, making parsing easier on the eye when names and datatypes > are close to each other. > > I looked for a way to make it italic or so instead, but it appears > wxWidgets doesn't support that - it can only set the formatting for > the whole header, which includes both the name and the datatype. > > Objections? Not sure I like it - it's better with ( ) instead of < >, but even so it looks ugly with array types and size bounded types. Personally I don't think the ugliness is worth it, especially given that (as you note) the type is on a separate line anyway. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Wed, Jun 27, 2012 at 5:56 PM, Dave Page <dpage@pgadmin.org> wrote: > On Wed, Jun 27, 2012 at 3:53 PM, Magnus Hagander <magnus@hagander.net> wrote: >> Attached patch changes the column headers in the query tool to put <> >> aronud the datatype. While it's already on a separate line, this makes >> it more clear which part is the datatype and which part is the name of >> the column, making parsing easier on the eye when names and datatypes >> are close to each other. >> >> I looked for a way to make it italic or so instead, but it appears >> wxWidgets doesn't support that - it can only set the formatting for >> the whole header, which includes both the name and the datatype. >> >> Objections? > > Not sure I like it - it's better with ( ) instead of < >, but even so > it looks ugly with array types and size bounded types. Hmm. I didn't try with arrays... > Personally I don't think the ugliness is worth it, especially given > that (as you note) the type is on a separate line anyway. Got any ideas for another way to differentiate the datatype more from the column name, that might work? (or correct my analysis and tell me that it *is* possible to make it italic or something like that) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/
On Wed, Jun 27, 2012 at 5:18 PM, Magnus Hagander <magnus@hagander.net> wrote: > On Wed, Jun 27, 2012 at 5:56 PM, Dave Page <dpage@pgadmin.org> wrote: >> On Wed, Jun 27, 2012 at 3:53 PM, Magnus Hagander <magnus@hagander.net> wrote: >>> Attached patch changes the column headers in the query tool to put <> >>> aronud the datatype. While it's already on a separate line, this makes >>> it more clear which part is the datatype and which part is the name of >>> the column, making parsing easier on the eye when names and datatypes >>> are close to each other. >>> >>> I looked for a way to make it italic or so instead, but it appears >>> wxWidgets doesn't support that - it can only set the formatting for >>> the whole header, which includes both the name and the datatype. >>> >>> Objections? >> >> Not sure I like it - it's better with ( ) instead of < >, but even so >> it looks ugly with array types and size bounded types. > > Hmm. I didn't try with arrays... > > >> Personally I don't think the ugliness is worth it, especially given >> that (as you note) the type is on a separate line anyway. > > Got any ideas for another way to differentiate the datatype more from > the column name, that might work? (or correct my analysis and tell me > that it *is* possible to make it italic or something like that) Nope. There's an outside chance you may be able to use an RTF string there, but I seriously doubt it. BTW; *if* you find a way, then the same change should be made to the edit grid. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Wed, 2012-06-27 at 17:24 +0100, Dave Page wrote: > On Wed, Jun 27, 2012 at 5:18 PM, Magnus Hagander <magnus@hagander.net> wrote: > > On Wed, Jun 27, 2012 at 5:56 PM, Dave Page <dpage@pgadmin.org> wrote: > >> On Wed, Jun 27, 2012 at 3:53 PM, Magnus Hagander <magnus@hagander.net> wrote: > >>> Attached patch changes the column headers in the query tool to put <> > >>> aronud the datatype. While it's already on a separate line, this makes > >>> it more clear which part is the datatype and which part is the name of > >>> the column, making parsing easier on the eye when names and datatypes > >>> are close to each other. > >>> > >>> I looked for a way to make it italic or so instead, but it appears > >>> wxWidgets doesn't support that - it can only set the formatting for > >>> the whole header, which includes both the name and the datatype. > >>> > >>> Objections? > >> > >> Not sure I like it - it's better with ( ) instead of < >, but even so > >> it looks ugly with array types and size bounded types. > > > > Hmm. I didn't try with arrays... > > > > > >> Personally I don't think the ugliness is worth it, especially given > >> that (as you note) the type is on a separate line anyway. > > > > Got any ideas for another way to differentiate the datatype more from > > the column name, that might work? Nope, sorry. The best idea would be a different style (italic or something else), but I don't see how to do that with wxWidgets 2.8. > (or correct my analysis and tell me > > that it *is* possible to make it italic or something like that) > > Nope. There's an outside chance you may be able to use an RTF string > there, but I seriously doubt it. > And so do I. > BTW; *if* you find a way, then the same change should be made to the edit grid. > +1 -- Guillaume http://blog.guillaume.lelarge.info http://www.dalibo.com
On Wed, Jun 27, 2012 at 10:42 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > On Wed, 2012-06-27 at 17:24 +0100, Dave Page wrote: >> On Wed, Jun 27, 2012 at 5:18 PM, Magnus Hagander <magnus@hagander.net> wrote: >> > On Wed, Jun 27, 2012 at 5:56 PM, Dave Page <dpage@pgadmin.org> wrote: >> >> On Wed, Jun 27, 2012 at 3:53 PM, Magnus Hagander <magnus@hagander.net> wrote: >> >>> Attached patch changes the column headers in the query tool to put <> >> >>> aronud the datatype. While it's already on a separate line, this makes >> >>> it more clear which part is the datatype and which part is the name of >> >>> the column, making parsing easier on the eye when names and datatypes >> >>> are close to each other. >> >>> >> >>> I looked for a way to make it italic or so instead, but it appears >> >>> wxWidgets doesn't support that - it can only set the formatting for >> >>> the whole header, which includes both the name and the datatype. >> >>> >> >>> Objections? >> >> >> >> Not sure I like it - it's better with ( ) instead of < >, but even so >> >> it looks ugly with array types and size bounded types. >> > >> > Hmm. I didn't try with arrays... >> > >> > >> >> Personally I don't think the ugliness is worth it, especially given >> >> that (as you note) the type is on a separate line anyway. >> > >> > Got any ideas for another way to differentiate the datatype more from >> > the column name, that might work? > > Nope, sorry. The best idea would be a different style (italic or > something else), but I don't see how to do that with wxWidgets 2.8. > >> (or correct my analysis and tell me >> > that it *is* possible to make it italic or something like that) >> >> Nope. There's an outside chance you may be able to use an RTF string >> there, but I seriously doubt it. >> > > And so do I. Yeah, seems not ot be there.. The other option would be to make it configurable (e.g. pick-your-character-or-none-at-all), but that seems like more work than it's worth... >> BTW; *if* you find a way, then the same change should be made to the edit grid. >> > > +1 Indeed. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/