Обсуждение: Limit the size of explainPopup

Hi,

I often use pgadmin's graphical explain to see how queries generated
be hibernate are planned&executed by postgresql, and it works really
well.
However, for very long queries pgadmin3 tries to create windows >
65536 pixels, which is not supported by X11 and therefor leads to
XErrors, which in turn cause pgadmin3 to close because of assetions.

I would propose to limit the size of the ExplainPopup to the screen
dimensions, please see the attached patch.

Thank you in advance, Clemens

On Sat, 2012-05-05 at 13:09 +0200, Clemens Eisserer wrote:
> Hi,
>
> I often use pgadmin's graphical explain to see how queries generated
> be hibernate are planned&executed by postgresql, and it works really
> well.
> However, for very long queries pgadmin3 tries to create windows >
> 65536 pixels, which is not supported by X11 and therefor leads to
> XErrors, which in turn cause pgadmin3 to close because of assetions.
>
> I would propose to limit the size of the ExplainPopup to the screen
> dimensions, please see the attached patch.
>

Seems good to me. So I commited it. I had to change it a lot to apply it
to master, but it's commited too there.

Thanks for your patch.


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

Hi Guillaume.

> Seems good to me. So I commited it. I had to change it a lot to apply it
> to master, but it's commited too there.
> Thanks for your patch.

Thanks for forward-porting and commiting :)

Thanks, Clemens