Обсуждение: Fwd: [pgadmin-support] 1.15 dev + wxWidgets 2.9.3, properties and index

Поиск
Список
Период
Сортировка

Fwd: [pgadmin-support] 1.15 dev + wxWidgets 2.9.3, properties and index

От
Akshay Joshi
Дата:
Hi Dave 

Attached is the patch that hopefully will fix the problem that Colin has faced. Patch also contains some other fixes too. I have tested it on Windows.
Please review it.  

---------- Forwarded message ----------
From: Dave Page <dpage@pgadmin.org>
Date: Mon, Mar 5, 2012 at 4:28 PM
Subject: Re: [pgadmin-support] 1.15 dev + wxWidgets 2.9.3, properties and index
To: Colin Beckingham <colbec@start.ca>
Cc: pgadmin-support@postgresql.org, Akshay Joshi <akshay.joshi@enterprisedb.com>


Akshay, can you look into this please?

(the "Adding duplicate image handler for 'PNG file'" thing shouldn't
matter - that's expected, though if you can figure out a way to fix
that, it'd be nice).

Thanks!

On Sat, Mar 3, 2012 at 8:01 PM, Colin Beckingham <colbec@start.ca> wrote:
> Two more issues with wxWidgets 2.9.3 on opensuse 12.1:
>
> 1. drill down through server, database, schema, public, tables
> 2. right click a specific table to bring up the context menu
> 3. most options work, however two items cause immediate fatal crash of
> pgadmin3:
> 4. click "properties" at bottom of menu
>
> $ /usr/local/pgadmin3/bin/pgadmin3
> 09:56:28 AM: Debug: Adding duplicate image handler for 'PNG file'
> ./src/common/sizer.cpp(1850): assert "m_growableRows[n] < nrows" failed in
> AdjustForGrowables(): invalid growable row index
> Trace/breakpoint trap
>
> 5. open indexes for a table, attempt to add new index:
>
> $ /usr/local/pgadmin3/bin/pgadmin3
> 09:58:24 AM: Debug: Adding duplicate image handler for 'PNG file'
> ./src/common/sizer.cpp(1850): assert "m_growableRows[n] < nrows" failed in
> AdjustForGrowables(): invalid growable row index
> Trace/breakpoint trap
>
> --
> ---
> Colin Beckingham
> 613-454-5369
> http://www.it4gh.com
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-support



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Senior Software Engineer 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246

Вложения

Re: Fwd: [pgadmin-support] 1.15 dev + wxWidgets 2.9.3, properties and index

От
Guillaume Lelarge
Дата:
On Mon, 2012-03-05 at 17:10 +0530, Akshay Joshi wrote:
> Hi Dave
>
> Attached is the patch that hopefully will fix the problem that Colin has
> faced. Patch also contains some other fixes too. I have tested it on
> Windows.
> Please review it.
>

Getting rid of the GrowableRows is not a good idea. They are useful to
make some widgets grow (more specificaly, the SQL text boxes in the SQL
tab).

Revised patch attached works for me.


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com

Вложения

Re: Fwd: [pgadmin-support] 1.15 dev + wxWidgets 2.9.3, properties and index

От
Guillaume Lelarge
Дата:
On Mon, 2012-03-05 at 13:30 +0100, Guillaume Lelarge wrote:
> On Mon, 2012-03-05 at 17:10 +0530, Akshay Joshi wrote:
> > Hi Dave
> >
> > Attached is the patch that hopefully will fix the problem that Colin has
> > faced. Patch also contains some other fixes too. I have tested it on
> > Windows.
> > Please review it.
> >
>
> Getting rid of the GrowableRows is not a good idea. They are useful to
> make some widgets grow (more specificaly, the SQL text boxes in the SQL
> tab).
>
> Revised patch attached works for me.
>

I added another fix to the patch, and pushed the whole. Thanks Akshay.


--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com