Обсуждение: wxOGL licence change

Поиск
Список
Период
Сортировка

wxOGL licence change

От
Peter Geoghegan
Дата:
OGL source files incorrectly indicate that they're wxWindows licensed.
How would you like to fix this?

--
Regards,
Peter Geoghegan

Re: wxOGL licence change

От
Dave Page
Дата:
On Wed, Feb 16, 2011 at 8:52 PM, Peter Geoghegan
<peter.geoghegan86@gmail.com> wrote:
> OGL source files incorrectly indicate that they're wxWindows licensed.
> How would you like to fix this?

We should probably replace the headers with our standard ones, but
include a copyright line naming Julian - much like the PG ones:

 * Portions Copyright (c) 1996-2010, PostgreSQL Global Development Group
 * Portions Copyright (c) 1994, Regents of the University of California


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: wxOGL licence change

От
Peter Geoghegan
Дата:
I hesitate to substantially change the existing headers, which have
Julian's old copyright - this might be useful in the future.

What do you think?

I've noticed that OGL has mac style \r line endings. I'd like to
change this, if only because it causes the web interface to git from
displaying dirty big |\r| things everywhere. Objections? Actually,
maybe this could be the justification for assigning portions of the
copyright of each source file to the pgAdmin development team.   :-)

--
Regards,
Peter Geoghegan

Re: wxOGL licence change

От
Dave Page
Дата:
On Thu, Feb 17, 2011 at 2:40 AM, Peter Geoghegan
<peter.geoghegan86@gmail.com> wrote:
> I hesitate to substantially change the existing headers, which have
> Julian's old copyright - this might be useful in the future.
>
> What do you think?

Well, we can add ours above them I suppose. I'm not that worried about
keeping them though, as long as we properly credit Julian. We have
them in GIT for any historic needs.

BTW, can you please send me the permission to relicence emails,
complete with headers?

> I've noticed that OGL has mac style \r line endings. I'd like to
> change this, if only because it causes the web interface to git from
> displaying dirty big |\r| things everywhere. Objections? Actually,
> maybe this could be the justification for assigning portions of the
> copyright of each source file to the pgAdmin development team.   :-)

I already removed the DLL linkage macros and fixed the precompiled
headers - that should be justification enough :-). I have just run
"make style" as well though - that should have fixed the line endings
(\r? Really? Julian must be supporting some really old apps!)


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company