Обсуждение: Feature: visual feedback of disabled triggers
Hi, I would like to suggest you a simple feature : is it possible to add, in the left panel of pgAdmin (objects browser), a visual feedback of disabled triggers (like a red cross, for example, or a greyed icon) ? Thanks in advance, -- Erika
Le 04/02/2011 11:42, R.I.K a écrit : > [...] > I would like to suggest you a simple feature : is it possible to add, in > the left panel of pgAdmin (objects browser), a visual feedback of > disabled triggers (like a red cross, for example, or a greyed icon) ? > I think the greyed icon would be best. If we want to do this, we need to do this for rules too. -- Guillaume http://www.postgresql.fr http://dalibo.com
On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 04/02/2011 11:42, R.I.K a écrit : >> [...] >> I would like to suggest you a simple feature : is it possible to add, in >> the left panel of pgAdmin (objects browser), a visual feedback of >> disabled triggers (like a red cross, for example, or a greyed icon) ? >> > > I think the greyed icon would be best. If we want to do this, we need to > do this for rules too. We use a red cross for disconnected databases. I think it should be consistent with that. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 08/02/2011 07:48, Dave Page a écrit : > On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 04/02/2011 11:42, R.I.K a écrit : >>> [...] >>> I would like to suggest you a simple feature : is it possible to add, in >>> the left panel of pgAdmin (objects browser), a visual feedback of >>> disabled triggers (like a red cross, for example, or a greyed icon) ? >>> >> >> I think the greyed icon would be best. If we want to do this, we need to >> do this for rules too. > > We use a red cross for disconnected databases. I think it should be > consistent with that. > OK, I added a ticket on that. -- Guillaume http://www.postgresql.fr http://dalibo.com
Le 09/02/2011 23:11, Guillaume Lelarge a écrit : > Le 08/02/2011 07:48, Dave Page a écrit : >> On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >>> Le 04/02/2011 11:42, R.I.K a écrit : >>>> [...] >>>> I would like to suggest you a simple feature : is it possible to add, in >>>> the left panel of pgAdmin (objects browser), a visual feedback of >>>> disabled triggers (like a red cross, for example, or a greyed icon) ? >>>> >>> >>> I think the greyed icon would be best. If we want to do this, we need to >>> do this for rules too. >> >> We use a red cross for disconnected databases. I think it should be >> consistent with that. >> > > OK, I added a ticket on that. > Worked on it. Results available in this git branch: https://github.com/gleu/pgadmin3/tree/ticket306 Patch attached with a screenshot. Comments? -- Guillaume http://www.postgresql.fr http://dalibo.com
Вложения
Le 06/03/2011 16:16, Guillaume Lelarge a écrit : > Le 09/02/2011 23:11, Guillaume Lelarge a écrit : >> Le 08/02/2011 07:48, Dave Page a écrit : >>> On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>>> Le 04/02/2011 11:42, R.I.K a écrit : >>>>> [...] >>>>> I would like to suggest you a simple feature : is it possible to add, in >>>>> the left panel of pgAdmin (objects browser), a visual feedback of >>>>> disabled triggers (like a red cross, for example, or a greyed icon) ? >>>>> >>>> >>>> I think the greyed icon would be best. If we want to do this, we need to >>>> do this for rules too. >>> >>> We use a red cross for disconnected databases. I think it should be >>> consistent with that. >>> >> >> OK, I added a ticket on that. >> > > Worked on it. Results available in this git branch: > > https://github.com/gleu/pgadmin3/tree/ticket306 > > Patch attached with a screenshot. > > Comments? > BTW, rules could use the same visual hint. See this branch for the implementation: https://github.com/gleu/pgadmin3/tree/rules Comments welcomed. -- Guillaume http://www.postgresql.fr http://dalibo.com
On Sun, Mar 6, 2011 at 3:16 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 09/02/2011 23:11, Guillaume Lelarge a écrit : >> Le 08/02/2011 07:48, Dave Page a écrit : >>> On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>>> Le 04/02/2011 11:42, R.I.K a écrit : >>>>> [...] >>>>> I would like to suggest you a simple feature : is it possible to add, in >>>>> the left panel of pgAdmin (objects browser), a visual feedback of >>>>> disabled triggers (like a red cross, for example, or a greyed icon) ? >>>>> >>>> >>>> I think the greyed icon would be best. If we want to do this, we need to >>>> do this for rules too. >>> >>> We use a red cross for disconnected databases. I think it should be >>> consistent with that. >>> >> >> OK, I added a ticket on that. >> > > Worked on it. Results available in this git branch: > > https://github.com/gleu/pgadmin3/tree/ticket306 > > Patch attached with a screenshot. The screenshot looks good, as does the patch at a quick glance. It's going to conflict with the one I'm working on though :-(. Guess it'll be a race to commit! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 07/03/2011 05:50, Dave Page a écrit : > On Sun, Mar 6, 2011 at 3:16 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 09/02/2011 23:11, Guillaume Lelarge a écrit : >>> Le 08/02/2011 07:48, Dave Page a écrit : >>>> On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge >>>> <guillaume@lelarge.info> wrote: >>>>> Le 04/02/2011 11:42, R.I.K a écrit : >>>>>> [...] >>>>>> I would like to suggest you a simple feature : is it possible to add, in >>>>>> the left panel of pgAdmin (objects browser), a visual feedback of >>>>>> disabled triggers (like a red cross, for example, or a greyed icon) ? >>>>>> >>>>> >>>>> I think the greyed icon would be best. If we want to do this, we need to >>>>> do this for rules too. >>>> >>>> We use a red cross for disconnected databases. I think it should be >>>> consistent with that. >>>> >>> >>> OK, I added a ticket on that. >>> >> >> Worked on it. Results available in this git branch: >> >> https://github.com/gleu/pgadmin3/tree/ticket306 >> >> Patch attached with a screenshot. > > The screenshot looks good, as does the patch at a quick glance. > > It's going to conflict with the one I'm working on though :-(. Guess > it'll be a race to commit! > I can wait for you to commit yours first if you want. Are you near ready to commit your patch? -- Guillaume http://www.postgresql.fr http://dalibo.com
On Mon, Mar 7, 2011 at 6:22 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 07/03/2011 05:50, Dave Page a écrit : >> On Sun, Mar 6, 2011 at 3:16 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >>> Le 09/02/2011 23:11, Guillaume Lelarge a écrit : >>>> Le 08/02/2011 07:48, Dave Page a écrit : >>>>> On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge >>>>> <guillaume@lelarge.info> wrote: >>>>>> Le 04/02/2011 11:42, R.I.K a écrit : >>>>>>> [...] >>>>>>> I would like to suggest you a simple feature : is it possible to add, in >>>>>>> the left panel of pgAdmin (objects browser), a visual feedback of >>>>>>> disabled triggers (like a red cross, for example, or a greyed icon) ? >>>>>>> >>>>>> >>>>>> I think the greyed icon would be best. If we want to do this, we need to >>>>>> do this for rules too. >>>>> >>>>> We use a red cross for disconnected databases. I think it should be >>>>> consistent with that. >>>>> >>>> >>>> OK, I added a ticket on that. >>>> >>> >>> Worked on it. Results available in this git branch: >>> >>> https://github.com/gleu/pgadmin3/tree/ticket306 >>> >>> Patch attached with a screenshot. >> >> The screenshot looks good, as does the patch at a quick glance. >> >> It's going to conflict with the one I'm working on though :-(. Guess >> it'll be a race to commit! >> > > I can wait for you to commit yours first if you want. Are you near ready > to commit your patch? No - after days of getting it to work on Windows, it just exploded horribly with GCC. Back to the drawing board :-( Please go ahead and commit. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 07/03/2011 07:27, Dave Page a écrit : > On Mon, Mar 7, 2011 at 6:22 AM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 07/03/2011 05:50, Dave Page a écrit : >>> On Sun, Mar 6, 2011 at 3:16 PM, Guillaume Lelarge >>> <guillaume@lelarge.info> wrote: >>>> Le 09/02/2011 23:11, Guillaume Lelarge a écrit : >>>>> Le 08/02/2011 07:48, Dave Page a écrit : >>>>>> On Tue, Feb 8, 2011 at 7:32 AM, Guillaume Lelarge >>>>>> <guillaume@lelarge.info> wrote: >>>>>>> Le 04/02/2011 11:42, R.I.K a écrit : >>>>>>>> [...] >>>>>>>> I would like to suggest you a simple feature : is it possible to add, in >>>>>>>> the left panel of pgAdmin (objects browser), a visual feedback of >>>>>>>> disabled triggers (like a red cross, for example, or a greyed icon) ? >>>>>>>> >>>>>>> >>>>>>> I think the greyed icon would be best. If we want to do this, we need to >>>>>>> do this for rules too. >>>>>> >>>>>> We use a red cross for disconnected databases. I think it should be >>>>>> consistent with that. >>>>>> >>>>> >>>>> OK, I added a ticket on that. >>>>> >>>> >>>> Worked on it. Results available in this git branch: >>>> >>>> https://github.com/gleu/pgadmin3/tree/ticket306 >>>> >>>> Patch attached with a screenshot. >>> >>> The screenshot looks good, as does the patch at a quick glance. >>> >>> It's going to conflict with the one I'm working on though :-(. Guess >>> it'll be a race to commit! >>> >> >> I can wait for you to commit yours first if you want. Are you near ready >> to commit your patch? > > No - after days of getting it to work on Windows, it just exploded > horribly with GCC. > > Back to the drawing board :-( > > Please go ahead and commit. > Thanks, done. -- Guillaume http://www.postgresql.fr http://dalibo.com