Обсуждение: Ticket 242: Add support for 9.1 ALTER TYPE new syntax
Hi, This patch adds support to the new ALTER TYPE syntax in 9.1. /me extracts the log message in the patch: I changed the Add/Change button with two buttons (Add and Change). The rest of the patch is used to allow the change on an existing type if we are connected to an 9.1+ release. Rather than trying to detect new. removed, and modified members, I simply drop all the old ones and add all the new ones. Much simpler, same results, and hopefully less bugs. Comments? (other than the fact that I forgot a TODO comment in that patch) -- Guillaume http://www.postgresql.fr http://dalibo.com
Le 28/10/2010 09:12, Guillaume Lelarge a écrit : > Hi, > > This patch adds support to the new ALTER TYPE syntax in 9.1. > > /me extracts the log message in the patch: > > I changed the Add/Change button with two buttons (Add and Change). The > rest of the patch is used to allow the change on an existing type if we > are connected to an 9.1+ release. > > Rather than trying to detect new. removed, and modified members, I > simply drop all the old ones and add all the new ones. Much simpler, > same results, and hopefully less bugs. > > Comments? (other than the fact that I forgot a TODO comment in that patch) > OK, this is just a silly patch. I should have read it before sending it. I'll send another one soon. -- Guillaume http://www.postgresql.fr http://dalibo.com
Le 28/10/2010 09:15, Guillaume Lelarge a écrit : > Le 28/10/2010 09:12, Guillaume Lelarge a écrit : >> Hi, >> >> This patch adds support to the new ALTER TYPE syntax in 9.1. >> >> /me extracts the log message in the patch: >> >> I changed the Add/Change button with two buttons (Add and Change). The >> rest of the patch is used to allow the change on an existing type if we >> are connected to an 9.1+ release. >> >> Rather than trying to detect new. removed, and modified members, I >> simply drop all the old ones and add all the new ones. Much simpler, >> same results, and hopefully less bugs. >> >> Comments? (other than the fact that I forgot a TODO comment in that patch) >> > > OK, this is just a silly patch. I should have read it before sending it. > I'll send another one soon. > > This one is the good one. Comments? -- Guillaume http://www.postgresql.fr http://dalibo.com
Le 28/10/2010 22:21, Guillaume Lelarge a écrit : > Le 28/10/2010 09:15, Guillaume Lelarge a écrit : >> Le 28/10/2010 09:12, Guillaume Lelarge a écrit : >>> Hi, >>> >>> This patch adds support to the new ALTER TYPE syntax in 9.1. >>> >>> /me extracts the log message in the patch: >>> >>> I changed the Add/Change button with two buttons (Add and Change). The >>> rest of the patch is used to allow the change on an existing type if we >>> are connected to an 9.1+ release. >>> >>> Rather than trying to detect new. removed, and modified members, I >>> simply drop all the old ones and add all the new ones. Much simpler, >>> same results, and hopefully less bugs. >>> >>> Comments? (other than the fact that I forgot a TODO comment in that patch) >>> >> >> OK, this is just a silly patch. I should have read it before sending it. >> I'll send another one soon. >> >> > > This one is the good one. > > Comments? > No comments since a few days, so commited :) -- Guillaume http://www.postgresql.fr http://dalibo.com