Обсуждение: Quiet logs for frmStatus
Hi, Here is a patch that make sure frmStatus will be quiet as much as possible with the logs. We missed to set log_min_duration_statement. I see it as a bug. So I would like to commit it on the 1.10 branch and on the trunk. But I'm not sure of it, and would like your opinions. BTW, I think it could be interesting to have this setup on each components of pgAdmin. We could add a global option that allows a user to make it verbose on the logs. Comments? Thanks. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Sun, May 9, 2010 at 5:16 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Hi, > > Here is a patch that make sure frmStatus will be quiet as much as > possible with the logs. We missed to set log_min_duration_statement. > > I see it as a bug. So I would like to commit it on the 1.10 branch and > on the trunk. But I'm not sure of it, and would like your opinions. Seems reasonable. > BTW, I think it could be interesting to have this setup on each > components of pgAdmin. We could add a global option that allows a user > to make it verbose on the logs. Comments? I don't see why we should override the server settings for other areas of the software. frmStatus makes sense, but elsewhere, less so. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com The Enterprise Postgres Company
Le 10/05/2010 14:30, Dave Page a écrit : > On Sun, May 9, 2010 at 5:16 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Hi, >> >> Here is a patch that make sure frmStatus will be quiet as much as >> possible with the logs. We missed to set log_min_duration_statement. >> Seems I forgot the patch :) >> I see it as a bug. So I would like to commit it on the 1.10 branch and >> on the trunk. But I'm not sure of it, and would like your opinions. > > Seems reasonable. > OK, commited. >> BTW, I think it could be interesting to have this setup on each >> components of pgAdmin. We could add a global option that allows a user >> to make it verbose on the logs. Comments? > > I don't see why we should override the server settings for other areas > of the software. frmStatus makes sense, but elsewhere, less so. > Yeah, I think so too. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com