Обсуждение: Next patch for 8.5 support: WHEN clause in CREATE TRIGGER

Hi,

Here is a patch to add the support for this new 8.5 functionality. Ticket is
http://code.pgadmin.org/trac/ticket/99, commitfest item is
https://commitfest.postgresql.org/action/patch_view?id=198.

I don't really like the way I get the old WHEN clause, but I don't find
another way. Another thing that bothers me is the text field: it's one line
only. Perhaps a bit small?

Comments?


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

On Tue, Nov 24, 2009 at 6:48 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:
> Hi,
>
> Here is a patch to add the support for this new 8.5 functionality. Ticket is
> http://code.pgadmin.org/trac/ticket/99, commitfest item is
> https://commitfest.postgresql.org/action/patch_view?id=198.

Browsing the patch, I don't see anything too nasty :-)

> I don't really like the way I get the old WHEN clause, but I don't find
> another way.

I assume it's stored as a parsetree in the catalogs? It's not ideal to
extract it using a regexp, but it's not the end of the world.

> Another thing that bothers me is the text field: it's one line
> only. Perhaps a bit small?

Maybe - is there enough slack in the comment textbox to steal a line
or two, and add a vertical scrollbar?


--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Le mercredi 25 novembre 2009 à 09:48:31, Dave Page a écrit :
> On Tue, Nov 24, 2009 at 6:48 PM, Guillaume Lelarge
>
> <guillaume@lelarge.info> wrote:
> > Hi,
> >
> > Here is a patch to add the support for this new 8.5 functionality. Ticket
> > is http://code.pgadmin.org/trac/ticket/99, commitfest item is
> > https://commitfest.postgresql.org/action/patch_view?id=198.
>
> Browsing the patch, I don't see anything too nasty :-)
>

Héhé.

> > I don't really like the way I get the old WHEN clause, but I don't find
> > another way.
>
> I assume it's stored as a parsetree in the catalogs? It's not ideal to
> extract it using a regexp, but it's not the end of the world.
>

AFAIK, there's no other way right now.

> > Another thing that bothers me is the text field: it's one line
> > only. Perhaps a bit small?
>
> Maybe - is there enough slack in the comment textbox to steal a line
> or two, and add a vertical scrollbar?
>

Yeah. I didn't remember at that time how to do it with the new dialog layout.
But I found and the new patch fixes this.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Le mercredi 2 décembre 2009 à 23:11:29, Guillaume Lelarge a écrit :
> Le mercredi 25 novembre 2009 à 09:48:31, Dave Page a écrit :
> > On Tue, Nov 24, 2009 at 6:48 PM, Guillaume Lelarge
> >
> > <guillaume@lelarge.info> wrote:
> > > Hi,
> > >
> > > Here is a patch to add the support for this new 8.5 functionality.
> > > Ticket is http://code.pgadmin.org/trac/ticket/99, commitfest item is
> > > https://commitfest.postgresql.org/action/patch_view?id=198.
> >
> > Browsing the patch, I don't see anything too nasty :-)
>
> Héhé.
>
> > > I don't really like the way I get the old WHEN clause, but I don't find
> > > another way.
> >
> > I assume it's stored as a parsetree in the catalogs? It's not ideal to
> > extract it using a regexp, but it's not the end of the world.
>
> AFAIK, there's no other way right now.
>
> > > Another thing that bothers me is the text field: it's one line
> > > only. Perhaps a bit small?
> >
> > Maybe - is there enough slack in the comment textbox to steal a line
> > or two, and add a vertical scrollbar?
>
> Yeah. I didn't remember at that time how to do it with the new dialog
>  layout. But I found and the new patch fixes this.
>

Commited.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com