Обсуждение: bugfix: dlgIndex column order

Hi, all

Bug fix:
    only when index's type is btree, user can set column order.
reported by: Obe, Regina

> I see that the new version of PgAdmin now automatically puts in for
> CREATE INDEX a
>
> the new NULLS FIRST / LAST clause for PostgreSQL 8.4.
>
> Unfortunately when you try to use this for a gist index -- it generates
> something like this
>
> CREATE INDEX mytable_idx_the_geom
>    ON mytable USING gist (poi_geom ASC NULLS LAST);
>
> Which generates an error from PostgreSQL like this.
>
>  access method "gist" does not support ASC/DESC options
>
> There doesn't seem to be a way to turn this off except by explicitly
> editing the SQL statement to remove the ASC clause.  Can we have it not
> enabled by default or if we must -- allow this to be unchecked.
>
> Thanks,
> Regina

-----------------------------------------------
Quan Zongliang
quanzongliang@gmail.com
CIT JAPAN: http://www.cit.co.jp
CIT CHINA: http://www.citbj.com.cn

> Bug fix:
>     only when index's type is btree, user can set column order.
> reported by: Obe, Regina
Sorry, I found the function Go() is missed.
It should be modified too.
Please wait.

-----------------------------------------------
Quan Zongliang
quanzongliang@gmail.com
CIT JAPAN: http://www.cit.co.jp
CIT CHINA: http://www.citbj.com.cn

new patch, check it

-----------------------------------------------
Quan Zongliang
quanzongliang@gmail.com
CIT JAPAN: http://www.cit.co.jp
CIT CHINA: http://www.citbj.com.cn

On Mon, May 18, 2009 at 3:37 AM, Quan Zongliang <quanzongliang@gmail.com> wrote:
> new patch, check it

It seems overly complex to me. What about something like the attached?

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

> It seems overly complex to me. What about something like the attached?
It's good. no problem.

But the function "int dlgIndex::Go(bool modal)" should be fixed to display
correct column property. When index is hash, gist or gin, only column name
should be displayed.

-----------------------------------------------
Quan Zongliang
quanzongliang@gmail.com
CIT JAPAN: http://www.cit.co.jp
CIT CHINA: http://www.citbj.com.cn

2009/5/19 Quan Zongliang <quanzongliang@gmail.com>:
>> It seems overly complex to me. What about something like the attached?
> It's good. no problem.
>
> But the function "int dlgIndex::Go(bool modal)" should be fixed to display
> correct column property. When index is hash, gist or gin, only column name
> should be displayed.

Ahh, yes - well spotted. How's this?


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

> Ahh, yes - well spotted. How's this?
It's ok.

-----------------------------------------------
Quan Zongliang
quanzongliang@gmail.com
CIT JAPAN: http://www.cit.co.jp
CIT CHINA: http://www.citbj.com.cn

Two very minor fixes for Greenplum:

1.  If html help is available (GPDB 3.3.0 and later), prefer it to the .PDF help.
2.  If we can't find local GPDB help, go to Greenplum web site for it.

On Fri, May 22, 2009 at 6:11 PM, Chuck McDevitt <cmcdevitt@greenplum.com> wrote:
> Two very minor fixes for Greenplum:
>
> 1.  If html help is available (GPDB 3.3.0 and later), prefer it to the .PDF help.

I've tweaked that somewhat. I've removed the test for GPHOME and
GPHOME_CLIENTS which doesn't seem to help much, and moved the test
outside of the #ifdef block it's in which is a test for HTMLHelp
compatibility. I've moved the PDF test after the index.html test.

> 2.  If we can't find local GPDB help, go to Greenplum web site for it.

Applied - thanks.

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com