Обсуждение: Patch : "Change the panel in tabs was setting the top switches to SQL Editor"
Hi Dave Page, > I think - this is a bug from a while, I can reproduce the same for the > "Criteria Panel". > If I make any changes in the "Criteria Panel", and then click "Columns > Panel", the main > tab set at the top switches to "SQL Editor". :( > > I will send a patch for it. As I have told you, this was a bug introduced earlier. The object sqlNoteBook (in frmQuery class) and the object tabs (in the gqbController class) both were using the same id (CTL_NTBKCENTER). And in frmQuery class, an event handler - OnChangeNotebook is registered with this id. I changed the id for the object tabs of gqbController to CTL_NTBKPANELS. Please find the patch for the same. Regards, Ashesh Index: gqb/gqbController.cpp =================================================================== --- gqb/gqbController.cpp (revision 7506) +++ gqb/gqbController.cpp (working copy) @@ -27,6 +27,8 @@ #include "gqb/gqbEvents.h" #include "gqb/gqbViewPanels.h" +wxWindowID CTL_NTBKPANELS = ::wxNewId(); + gqbController::gqbController(gqbModel *_model, wxWindow *gqbParent, wxNotebook *gridParent, wxSize size=wxSize(800,1280)): wxObject() { @@ -36,7 +38,7 @@ // Initialize Main Splitter gqbMainContainer = new wxSplitterWindow(gqbParent,GQB_HORZ_SASH,wxDefaultPosition,wxDefaultSize,wxSP_3D); - tabs = new wxNotebook(gqbMainContainer, CTL_NTBKCENTER, wxDefaultPosition, wxDefaultSize); + tabs = new wxNotebook(gqbMainContainer, CTL_NTBKPANELS, wxDefaultPosition, wxDefaultSize); // Initialize view container with tables browser // GQB-TODO: change 976 with a enum value of events.h
Re: Patch : "Change the panel in tabs was setting the top switches to SQL Editor"
От
"Dave Page"
Дата:
On Thu, Dec 4, 2008 at 10:36 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote: > Hi Dave Page, >> >> I think - this is a bug from a while, I can reproduce the same for the >> "Criteria Panel". >> If I make any changes in the "Criteria Panel", and then click "Columns >> Panel", the main >> tab set at the top switches to "SQL Editor". :( >> >> I will send a patch for it. > > As I have told you, this was a bug introduced earlier. > The object sqlNoteBook (in frmQuery class) and the object tabs (in the > gqbController class) > both were using the same id (CTL_NTBKCENTER). > And in frmQuery class, an event handler - OnChangeNotebook is registered > with this id. > > I changed the id for the object tabs of gqbController to CTL_NTBKPANELS. > > Please find the patch for the same. thanks - patch applied. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com