Обсуждение: Dialogue issue
Hi, Just spotted a dialogue which seems to be having, umm, border issues! Please see the attached screenshot - you'll see what I mean :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Вложения
Hi, Sorry for not being much available right now. Dave Page a écrit : > > Just spotted a dialogue which seems to be having, umm, border issues! > Please see the attached screenshot - you'll see what I mean :-) > Do you mean the OK/Cancel button ? or the password textfield ? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Tue, Sep 16, 2008 at 10:43 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Hi, > > Sorry for not being much available right now. No problem - we all get busy from time time time. > Dave Page a écrit : >> >> Just spotted a dialogue which seems to be having, umm, border issues! >> Please see the attached screenshot - you'll see what I mean :-) >> > > Do you mean the OK/Cancel button ? or the password textfield ? Both - they're really close to the edge of the dialogue. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Tue, Sep 16, 2008 at 10:43 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> >> Sorry for not being much available right now. > > No problem - we all get busy from time time time. > >> Dave Page a écrit : >>> Just spotted a dialogue which seems to be having, umm, border issues! >>> Please see the attached screenshot - you'll see what I mean :-) >>> >> Do you mean the OK/Cancel button ? or the password textfield ? > > Both - they're really close to the edge of the dialogue. > Hope it's better with this patch. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/ui/dlgConnect.xrc =================================================================== --- pgadmin/ui/dlgConnect.xrc (révision 7479) +++ pgadmin/ui/dlgConnect.xrc (copie de travail) @@ -32,7 +32,7 @@ <tooltip>Enter the password to use when connecting to the server.</tooltip> </object> <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> - <border>4</border> + <border>8</border> </object> <object class="spacer"> <size>10,10d</size> @@ -67,7 +67,8 @@ <border>3</border> </object> </object> - <flag>wxEXPAND|wxTOP|wxLEFT|wxRIGHT</flag> + <flag>wxEXPAND|wxALL</flag> + <border>4</border> </object> </object> </object>
On Thu, Sep 18, 2008 at 3:40 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> Both - they're really close to the edge of the dialogue. >> > > Hope it's better with this patch. Certainly better - I think it perhaps needs the same spacing added again though? What do you think? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Thu, Sep 18, 2008 at 3:40 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: > >>> Both - they're really close to the edge of the dialogue. >>> >> Hope it's better with this patch. > > Certainly better - I think it perhaps needs the same spacing added > again though? What do you think? > Yes, this is much better. See attached patch. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/ui/dlgConnect.xrc =================================================================== --- pgadmin/ui/dlgConnect.xrc (révision 7479) +++ pgadmin/ui/dlgConnect.xrc (copie de travail) @@ -32,7 +32,7 @@ <tooltip>Enter the password to use when connecting to the server.</tooltip> </object> <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> - <border>4</border> + <border>12</border> </object> <object class="spacer"> <size>10,10d</size> @@ -67,7 +67,8 @@ <border>3</border> </object> </object> - <flag>wxEXPAND|wxTOP|wxLEFT|wxRIGHT</flag> + <flag>wxEXPAND|wxALL</flag> + <border>8</border> </object> </object> </object>
On Thu, Sep 18, 2008 at 11:02 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> Certainly better - I think it perhaps needs the same spacing added >> again though? What do you think? >> > > Yes, this is much better. See attached patch. Yup - I've tweaked it a little more (put the checkbox under the password box) and committed. Feel free to tweak some more if you don't like what I did :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Thu, Sep 18, 2008 at 11:02 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >>> Certainly better - I think it perhaps needs the same spacing added >>> again though? What do you think? >>> >> Yes, this is much better. See attached patch. > > Yup - I've tweaked it a little more (put the checkbox under the > password box) and committed. Feel free to tweak some more if you don't > like what I did :-) > It seems good to me. Thanks. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com