Обсуждение: OK button with no Alt key

Hi all,

Alt-O is not available on dlgEditGridOptions on Windows. If I edit
dlgEditGridOptions.xrc, I see this :
  <label>OK</label>

There's no & in front of OK. In fact, all dlg*.xrc has no & in
front of OK label. I wonder if this is on purpose ? because it works on
Linux. I don't know what to think about this. Any ideas ?

Thanks.


--
Guillaume.
<!-- http://abs.traduc.org/
     http://lfs.traduc.org/
     http://docs.postgresqlfr.org/ -->

Guillaume Lelarge wrote:
> Hi all,
>
> Alt-O is not available on dlgEditGridOptions on Windows. If I edit
> dlgEditGridOptions.xrc, I see this :
>   <label>OK</label>
>
> There's no & in front of OK. In fact, all dlg*.xrc has no & in
> front of OK label. I wonder if this is on purpose ? because it works on
> Linux. I don't know what to think about this. Any ideas ?

Hi Guillame,

I see no reason not to add these except that it will need re-translation.

Regards, Dave.

Hi Dave,

Dave Page a écrit :
> Guillaume Lelarge wrote:
>> Alt-O is not available on dlgEditGridOptions on Windows. If I edit
>> dlgEditGridOptions.xrc, I see this :
>>   <label>OK</label>
>>
>> There's no & in front of OK. In fact, all dlg*.xrc has no & in
>> front of OK label. I wonder if this is on purpose ? because it works on
>> Linux. I don't know what to think about this. Any ideas ?
>
> I see no reason not to add these except that it will need re-translation.
>

You're right. That means at most four new strings... not a really big
deal. So, I've commited this change to add shortcut keys on OK, Cancel,
Apply and Help buttons for dialog windows.

Regards.


--
Guillaume.
<!-- http://abs.traduc.org/
     http://lfs.traduc.org/
     http://docs.postgresqlfr.org/ -->

Guillaume Lelarge a écrit :
> Dave Page a écrit :
>> Guillaume Lelarge wrote:
>>> Alt-O is not available on dlgEditGridOptions on Windows. If I edit
>>> dlgEditGridOptions.xrc, I see this :
>>>   <label>OK</label>
>>>
>>> There's no & in front of OK. In fact, all dlg*.xrc has no & in
>>> front of OK label. I wonder if this is on purpose ? because it works on
>>> Linux. I don't know what to think about this. Any ideas ?
>> I see no reason not to add these except that it will need re-translation.
>>
>
> You're right. That means at most four new strings... not a really big
> deal. So, I've commited this change to add shortcut keys on OK, Cancel,
> Apply and Help buttons for dialog windows.
>

I wonder how I can test this on Windows without having to compile it (I
will need to compile pgAdmin on Windows real soon, but don't have the
time right now). Do we have a nightly-build for windows ?

Thanks.


--
Guillaume.
<!-- http://abs.traduc.org/
     http://lfs.traduc.org/
     http://docs.postgresqlfr.org/ -->

Guillaume Lelarge wrote:
> Guillaume Lelarge a écrit :
>> Dave Page a écrit :
>>> Guillaume Lelarge wrote:
>>>> Alt-O is not available on dlgEditGridOptions on Windows. If I edit
>>>> dlgEditGridOptions.xrc, I see this :
>>>>   <label>OK</label>
>>>>
>>>> There's no & in front of OK. In fact, all dlg*.xrc has no & in
>>>> front of OK label. I wonder if this is on purpose ? because it works on
>>>> Linux. I don't know what to think about this. Any ideas ?
>>> I see no reason not to add these except that it will need re-translation.
>>>
>> You're right. That means at most four new strings... not a really big
>> deal. So, I've commited this change to add shortcut keys on OK, Cancel,
>> Apply and Help buttons for dialog windows.
>>
>
> I wonder how I can test this on Windows without having to compile it (I
> will need to compile pgAdmin on Windows real soon, but don't have the
> time right now). Do we have a nightly-build for windows ?

No, but &OK does work - I tested it earlier.

/D

Dave Page a écrit :
> Guillaume Lelarge wrote:
>> Guillaume Lelarge a écrit :
>>> Dave Page a écrit :
>>>> Guillaume Lelarge wrote:
>>>>> Alt-O is not available on dlgEditGridOptions on Windows. If I edit
>>>>> dlgEditGridOptions.xrc, I see this :
>>>>>   <label>OK</label>
>>>>>
>>>>> There's no & in front of OK. In fact, all dlg*.xrc has no & in
>>>>> front of OK label. I wonder if this is on purpose ? because it works on
>>>>> Linux. I don't know what to think about this. Any ideas ?
>>>> I see no reason not to add these except that it will need re-translation.
>>>>
>>> You're right. That means at most four new strings... not a really big
>>> deal. So, I've commited this change to add shortcut keys on OK, Cancel,
>>> Apply and Help buttons for dialog windows.
>>>
>> I wonder how I can test this on Windows without having to compile it (I
>> will need to compile pgAdmin on Windows real soon, but don't have the
>> time right now). Do we have a nightly-build for windows ?
>
> No, but &OK does work - I tested it earlier.
>

Oh great. Thanks.


--
Guillaume.
<!-- http://abs.traduc.org/
     http://lfs.traduc.org/
     http://docs.postgresqlfr.org/ -->