Обсуждение: SVN Commit by dpage: r6424 - trunk/pgadmin3/pkg/win32/src

Поиск
Список
Период
Сортировка

SVN Commit by dpage: r6424 - trunk/pgadmin3/pkg/win32/src

От
svn@pgadmin.org
Дата:
Author: dpage

Date: 2007-07-13 12:55:41 +0000 (Fri, 13 Jul 2007)

New Revision: 6424

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6424&view=rev

Log:
Looks like we need gssapi32.dll as well now :-(


Modified:
   trunk/pgadmin3/pkg/win32/src/pgadmin3.wxs

Re: SVN Commit by dpage: r6424 - trunk/pgadmin3/pkg/win32/src

От
Magnus Hagander
Дата:
svn@pgadmin.org wrote:
> Author: dpage
>
> Date: 2007-07-13 12:55:41 +0000 (Fri, 13 Jul 2007)
>
> New Revision: 6424
>
> Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6424&view=rev
>
> Log:
> Looks like we need gssapi32.dll as well now :-(
>
>
> Modified:
>    trunk/pgadmin3/pkg/win32/src/pgadmin3.wxs

Uh, does this mean we're shipping a 8.3 pre-release version of libpq
with the new version? Is that a great idea?

Because AFAIK the gssapi requirement should only be on 8.3 - if it's on
8.2 then I messed something up...

//Magnus


Re: SVN Commit by dpage: r6424 - trunk/pgadmin3/pkg/win32/src

От
Dave Page
Дата:
Magnus Hagander wrote:
> svn@pgadmin.org wrote:
>> Author: dpage
>>
>> Date: 2007-07-13 12:55:41 +0000 (Fri, 13 Jul 2007)
>>
>> New Revision: 6424
>>
>> Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6424&view=rev
>>
>> Log:
>> Looks like we need gssapi32.dll as well now :-(
>>
>>
>> Modified:
>>    trunk/pgadmin3/pkg/win32/src/pgadmin3.wxs
>
> Uh, does this mean we're shipping a 8.3 pre-release version of libpq
> with the new version? Is that a great idea?

Yes, because we use 8.3-only features of pg_dump etc. so we can't get
them tested unless we ship them.

When we actually release, well, we'll see how close to release PG is and
how confident we are about the 8.3 libpq and pg_dump etc.

> Because AFAIK the gssapi requirement should only be on 8.3 - if it's on
> 8.2 then I messed something up...

It is. I didn't realise it would suddenly require gssapi32.dll by
default though.

/D

Re: SVN Commit by dpage: r6424 - trunk/pgadmin3/pkg/win32/src

От
Magnus Hagander
Дата:
Dave Page wrote:
> Magnus Hagander wrote:
>> svn@pgadmin.org wrote:
>>> Author: dpage
>>>
>>> Date: 2007-07-13 12:55:41 +0000 (Fri, 13 Jul 2007)
>>>
>>> New Revision: 6424
>>>
>>> Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6424&view=rev
>>>
>>> Log:
>>> Looks like we need gssapi32.dll as well now :-(
>>>
>>>
>>> Modified:
>>>    trunk/pgadmin3/pkg/win32/src/pgadmin3.wxs
>> Uh, does this mean we're shipping a 8.3 pre-release version of libpq
>> with the new version? Is that a great idea?
>
> Yes, because we use 8.3-only features of pg_dump etc. so we can't get
> them tested unless we ship them.
> When we actually release, well, we'll see how close to release PG is and
> how confident we are about the 8.3 libpq and pg_dump etc.

Ok. It's a potential problem, but since pg is in freeze it shouldn't be
impossible :-)


>> Because AFAIK the gssapi requirement should only be on 8.3 - if it's on
>> 8.2 then I messed something up...
>
> It is. I didn't realise it would suddenly require gssapi32.dll by
> default though.

It's not. However, if you build with msvc, it's automatically included
if you build with Kerberos support since they come from the same
package. On mingw, you have a separate config parameter.

//Magnus