Обсуждение: Two small bugs

I just ran across two bugs. I started looking into it myself, but it
looks like Dave or Andreas will be able to fix these far faster than I
can.

First issue - it is impossible to change the properties of a server
unless you have at least one active server connection.

Steps to Reproduce:

1) Make sure at least 2 servers are registered
2) Start a fresh instance of pgAdmin
3) Click on a server name - the properties toolbar icon will be disabled
4) Open a connection to one of the registered servers
5) Click on either server name - the properties toolbar icon will now
be enabled

The expected behavior was for the toolbar icon to be enabled at step 3.

Second bug - the properties button (and delete button too) are enabled
when clicking the root of the browser tree.

Steps to Reproduce

1) Follow 1 thru 5 above
2) Click the root of the browser tree
3) Click the Properties toolbar icon - pgAdmin will crash

Ed

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Edward Di Geronimo Jr.
> Sent: 19 May 2006 04:22
> To: pgadmin-hackers@postgresql.org
> Subject: [pgadmin-hackers] Two small bugs
>
> I just ran across two bugs. I started looking into it myself,
> but it looks like Dave or Andreas will be able to fix these
> far faster than I can.
>
> First issue - it is impossible to change the properties of a
> server unless you have at least one active server connection.
>
> Steps to Reproduce:
>
> 1) Make sure at least 2 servers are registered
> 2) Start a fresh instance of pgAdmin
> 3) Click on a server name - the properties toolbar icon will
> be disabled
> 4) Open a connection to one of the registered servers
> 5) Click on either server name - the properties toolbar icon
> will now be enabled
>
> The expected behavior was for the toolbar icon to be enabled
> at step 3.
>
> Second bug - the properties button (and delete button too)
> are enabled when clicking the root of the browser tree.
>
> Steps to Reproduce
>
> 1) Follow 1 thru 5 above
> 2) Click the root of the browser tree
> 3) Click the Properties toolbar icon - pgAdmin will crash

Yeah - I had actually spotted that the other day. I'm pretty sure it's
new so I probably broke something recently. Will look.

Thanks, Dave.

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Dave Page
> Sent: 19 May 2006 08:21
> To: Edward Di Geronimo Jr.; pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Two small bugs
>
>
> Yeah - I had actually spotted that the other day. I'm pretty
> sure it's new so I probably broke something recently. Will look.

Yeah, it was my fault - broken by 5162. Difficult one to find
unfortunately as it only crashed in release builds so I had to debug it
entirely using wxLogInfo().

Anyway, should be OK now.

Thanks, Dave