Обсуждение: pgAgent stuff
Dave, calling the jobid simply id collided with pgObject::GetId, which returns a wxTreeItemId; I changed it throughout the sources, please check if It is complete. Some days ago I noticed you remove pgAgent.cpp, which showed an instance of pgAgent if the schema is present. Why did you remove it? How should a job be added? Regards, Andreas
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 02 March 2005 23:50 > To: Dave Page > Cc: pgadmin-hackers@postgresql.org > Subject: pgAgent stuff > > Dave, > > calling the jobid simply id collided with pgObject::GetId, > which returns > a wxTreeItemId; I changed it throughout the sources, please > check if It > is complete. Ack, good catch - thnaks. > Some days ago I noticed you remove pgAgent.cpp, which showed > an instance > of pgAgent if the schema is present. Why did you remove it? > How should a > job be added? I removed it because it was easier to use a pgCollection than to make pgAgent work properly and consistently with the rest of the browser. Consequently, the code should be easier to grok and maintain as it now works the same way as other object collections. The schema detection is still there - it's just moved into pgDatabase.cpp, which only adds the Jobs node to the tree if pgagent.pga_jobs exists (that had a typo in it last night btw - 'tis fixed now). A job is added in precisely the same way as any other object is added, and steps/schedules are added either as part of the initial job definition, or as separate objects under the Schedules/Steps nodes. Regards, Dave.
Dave Page wrote: > >>Some days ago I noticed you remove pgAgent.cpp, which showed >>an instance of pgAgent if the schema is present. > > I removed it because it was easier to use a pgCollection than to make > pgAgent work properly and consistently with the rest of the browser. > Consequently, the code should be easier to grok and maintain as it now > works the same way as other object collections. As as result from dropping pgAgent.cpp, there's no node where agent wide statistics (running agents, logs) can be displayed. IMHO we'll need to reinvent that node. Regards, Andreas
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 28 March 2005 18:06 > To: Dave Page > Cc: pgadmin-hackers@postgresql.org > Subject: Re: pgAgent stuff > > Dave Page wrote: > > > > >>Some days ago I noticed you remove pgAgent.cpp, which showed > >>an instance of pgAgent if the schema is present. > > > > I removed it because it was easier to use a pgCollection > than to make > > pgAgent work properly and consistently with the rest of the browser. > > Consequently, the code should be easier to grok and > maintain as it now > > works the same way as other object collections. > > As as result from dropping pgAgent.cpp, there's no node where > agent wide > statistics (running agents, logs) can be displayed. IMHO > we'll need to > reinvent that node. Eh? The node is there, I just rewrote it using pgCollection rather than a completely custom node type. pgCollection has stats code in which which can be extended as appropriate for the agent stuff. Regards, Dave.