Обсуждение: Re: CVS Commit by dpage: Don't save dialogue sizes

First, can we restrict this to one thread, not one public and one
private.

> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Andreas Pflug
> Sent: 11 October 2004 13:07
> To: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] CVS Commit by dpage: Don't
> save dialogue sizes
>
> cvs@cvs.pgadmin.org wrote:
> > Log Message:
> > -----------
> > Don't save dialogue sizes or positions if maximised or iconised.
>
> This patch not only doesn't fix anything for win32 dialogs.

It stops dialogues being restored to random positions if they were
maximised or minimised last time they were closed. That is the problem
that was reported. It does this by not updating the stored position/size
values if the dialogue is minimised or maximised. I have tested that the
position/size is correctly saved and restored for the normal case, and
that it is not overwritten when it shouldn't be.

What does it not do on your system?

> Additionally, it corrupts win32 frame handling, and gtk
> dialog and frame handling which worked ok until now.

In what way does it "corrupt" it? What steps do I need to take to
reproduce a problem?

Regards, Dave

Dave Page wrote:
> First, can we restrict this to one thread, not one public and one
> private.
>
>
>>-----Original Message-----
>>From: pgadmin-hackers-owner@postgresql.org
>>[mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
>>Andreas Pflug
>>Sent: 11 October 2004 13:07
>>To: pgadmin-hackers@postgresql.org
>>Subject: Re: [pgadmin-hackers] CVS Commit by dpage: Don't
>>save dialogue sizes
>>
>>cvs@cvs.pgadmin.org wrote:
>>
>>>Log Message:
>>>-----------
>>>Don't save dialogue sizes or positions if maximised or iconised.
>>
>>This patch not only doesn't fix anything for win32 dialogs.
>
>
> It stops dialogues being restored to random positions if they were
> maximised or minimised last time they were closed.

No. From a users perspective, restoring to non-max after a maximized
window is closed *is* random.

 From pgAdmin perspective, restoring to default pos because stored
values are bogus isn't different from restoring to stored default
positions from init code.

> That is the problem that was reported.

No the problem reported is "doesn't remember size if maximized". Those
maximizer guys don't care about the stored position which isn't
reflecting their previous window size.

  It does this by not updating the stored position/size
> values if the dialogue is minimised or maximised.

Thats the problem. the main app *did* handle this correctly before.

> In what way does it "corrupt" it? What steps do I need to take to
> reproduce a problem?

Maximize on gtk, close window, reopen.

Again:
the problem is not at store time, but at restore time. size/pos that are
not what the user wants are by no means better than bogus or
defaultsize/pos.
You invented bugs, without fixing anything.

Regards,
Andreas